1196078 - Please sign the plugin async init hotfix xpi (v20150818.01)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

To generate the XPI, do the following:

hg clone https://hg.mozilla.org/releases/firefox-hotfixes
cd firefox-hotfixes
HOTFIX=v20150818.01 make package

Then we need to sign the xpi generated at build/hotfix-v20150818.01.xpi

Comment 1

[Rail Aliiev [:rail]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1151537#c67 this is should be done by the AMO team. 

See also https://developer.mozilla.org/en-US/Add-ons/Hotfix

Comment 2

[Rail Aliiev [:rail]]

CCing people who can help with signing/deploying and fix the bz component I moved the bug in. :)

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: hotfix-v20150818.01.xpi

I'm attaching the unsigned build. Kris can you please sign it for me? I'm having some problems with the signing script.

Comment 4

[Jason Thomas [:jason]]

Attachment: hotfix-v20150818.01.xpi

signed hotfix

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Thank you, Jason.

The signed hotfix is now staged. We need someone to give it a test before we push live.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Jorge are you asking for help to find someone to test it, or is someone taking that over? I'm going to be offline for a few hours this afternoon, and want to make sure this keeps moving forward so we ship the fix as soon as we can.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

I think that going through some of these bugs would help in testing:
https://bugzilla.mozilla.org/showdependencytree.cgi?id=1195607&hide_resolved=1

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

We need to verify that the stage hotfix add-on is being correctly auto-installed and that it works. Pinging people who might be able to help with this.

Comment 9

[Vladan Djeric (:vladan)]

Aaron is in TRIBE, but he'll be done with TRIBE for the day within an hour.
How do we test it? Do I just install the XPI manually?

Comment 10

[Vladan Djeric (:vladan)]

I tested this hotfix on http://www.packers.com/media-center/videos/Thompson-on-player-evaluation-during-preseason/59e0dfdc-bd3f-4591-a876-bfe6d58a42f9

Firefox needs to be restarted for the hotfix to come into effect, but it fixes the Flash video playback issue on the above site once restarted. Pref is flipped correctly too. about:addons shows no sign of a hotfix

Comment 11

[Rail Aliiev [:rail]]

Not me, sorry. Probably someone from QE.

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Did you install the add-on manually or did you follow the instructions here?

Comment 13

[Jorge Villalobos [:jorgev] (he/him)]

Er, here: https://developer.mozilla.org/en-US/Add-ons/Hotfix#Testing_the_hotfix_on_the_staging_server

Comment 14

[Kamil Jozwiak [:kjozwiak]]

I'll go through this in about 30 minutes using the instructions that Jorge added via comment # 13

Comment 15

[Vladan Djeric (:vladan)]

I did install the add-on manually.

The instructions in that wiki didn't trigger an update check.
As a fallback, I triggered the check manually via Console (as described in wiki).
This did not install the hotfix.

Console log:

1440019962104	addons.manager	DEBUG	Background update check beginning
1440019962111	addons.repository	DEBUG	Repopulate add-on cache with ["{82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}", "{972ce4c6-7e08-4474-a285-3208198ce6fd}", "gmp-gmpopenh264", "gmp-eme-adobe", "{11ebf175-68f0-facd-27d3-4cef71bbfb48}", "{ebac7f17-deed-02bf-35b0-4794520bff20}", "{158919f4-92ff-8508-8fe9-94d77d36c1dc}", "{3c5cf738-08f9-8360-efdb-c3b58d08847a}", "{6e51f54f-5117-3863-ef08-142f34f17b29}", "{c958c6ca-bba4-45f8-6bf6-560ac0a873ec}", "{8f42271d-a471-4109-eb79-ac5b195eff21}", "{7b5b331d-0ae5-590b-1d0a-f74859917b57}", "{e184b9e5-1830-b353-6214-ff5b50ca31fb}", "{8d6c6140-008e-4b99-3e0e-10f38e69b2bb}", "{12b61fb1-c5d3-1ec9-b89c-692a67f2a6bc}", "{10c68f07-63a6-4653-8f43-9fc763f22443}"]
1440019962125	addons.repository	DEBUG	Requesting https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:%7B82AF8DCA-6DE9-405D-BD5E-43525BDAD38A%7D,%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D?src=firefox&appOS=WINNT&appVersion=40.0.2&tMain=279&tFirstPaint=1300&tSessionRestored=1523
1440019962515	addons.repository	DEBUG	Got metadata search load event
1440019962516	DeferredSave.addons.json	DEBUG	Save changes
1440019962516	DeferredSave.addons.json	DEBUG	Starting timer
1440019962568	DeferredSave.addons.json	DEBUG	Starting write
1440019962572	DeferredSave.addons.json	DEBUG	Write succeeded
1440019962572	addons.repository	DEBUG	Cache repopulated, setting extensions.getAddons.cache.lastUpdate to 1440019963
1440019962573	addons.xpi	DEBUG	updateAddonRepositoryData found 2 visible add-ons
1440019962582	addons.update-checker	DEBUG	Requesting https://addons-dev.allizom.org/update/VersionCheck.php?reqVersion=2&id={82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}&version=7.3.16540.9015&maxAppVersion=25.0a1&status=userDisabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=40.0.2&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=40.0.2&updateType=112&compatMode=normal
1440019962587	addons.update-checker	DEBUG	Requesting https://addons-dev.allizom.org/update/VersionCheck.php?reqVersion=2&id={972ce4c6-7e08-4474-a285-3208198ce6fd}&version=40.0.2&maxAppVersion=40.0.2&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=40.0.2&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=40.0.2&updateType=112&compatMode=normal
1440019962588	addons.manager	DEBUG	onUpdateFinished for gmp-gmpopenh264
1440019962588	addons.manager	DEBUG	onUpdateFinished for gmp-eme-adobe
1440019962589	addons.manager	DEBUG	onUpdateFinished for {11ebf175-68f0-facd-27d3-4cef71bbfb48}
1440019962589	addons.manager	DEBUG	onUpdateFinished for {ebac7f17-deed-02bf-35b0-4794520bff20}
1440019962589	addons.manager	DEBUG	onUpdateFinished for {158919f4-92ff-8508-8fe9-94d77d36c1dc}
1440019962589	addons.manager	DEBUG	onUpdateFinished for {3c5cf738-08f9-8360-efdb-c3b58d08847a}
1440019962589	addons.manager	DEBUG	onUpdateFinished for {6e51f54f-5117-3863-ef08-142f34f17b29}
1440019962589	addons.manager	DEBUG	onUpdateFinished for {c958c6ca-bba4-45f8-6bf6-560ac0a873ec}
1440019962590	addons.manager	DEBUG	onUpdateFinished for {8f42271d-a471-4109-eb79-ac5b195eff21}
1440019962590	addons.manager	DEBUG	onUpdateFinished for {7b5b331d-0ae5-590b-1d0a-f74859917b57}
1440019962590	addons.manager	DEBUG	onUpdateFinished for {e184b9e5-1830-b353-6214-ff5b50ca31fb}
1440019962590	addons.manager	DEBUG	onUpdateFinished for {8d6c6140-008e-4b99-3e0e-10f38e69b2bb}
1440019962590	addons.manager	DEBUG	onUpdateFinished for {12b61fb1-c5d3-1ec9-b89c-692a67f2a6bc}
1440019962590	addons.manager	DEBUG	onUpdateFinished for {10c68f07-63a6-4653-8f43-9fc763f22443}
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
1440019963188	addons.update-checker	WARN	Update manifest for {972ce4c6-7e08-4474-a285-3208198ce6fd} did not contain an updates property
1440019963189	addons.manager	DEBUG	onUpdateFinished for {972ce4c6-7e08-4474-a285-3208198ce6fd}
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
1440019963199	addons.update-checker	WARN	Update manifest for {82AF8DCA-6DE9-405D-BD5E-43525BDAD38A} did not contain an updates property
1440019963199	addons.manager	DEBUG	onUpdateFinished for {82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}
1440019963199	addons.update-checker	DEBUG	Requesting https://addons-dev.allizom.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=&maxAppVersion=%ITEM_MAXAPPVERSION%&status=userEnabled,incompatible&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=40.0.2&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=40.0.2&updateType=%UPDATE_TYPE%&compatMode=%COMPATIBILITY_MODE%
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
1440019963401	addons.manager	DEBUG	Background update check complete



This was the startup log (less important):

Could not read chrome manifest 'file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/chrome.manifest'.
1440019761806	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider"]
1440019761808	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]
1440019761810	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm
1440019761811	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm
1440019761811	addons.manager	DEBUG	Starting provider: XPIProvider
1440019761812	addons.xpi	DEBUG	startup
1440019761813	addons.xpi	INFO	Mapping {82AF8DCA-6DE9-405D-BD5E-43525BDAD38A} to C:\Program Files (x86)\Mozilla Firefox\browser\extensions\{82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}.xpi
1440019761813	addons.xpi	INFO	Mapping {972ce4c6-7e08-4474-a285-3208198ce6fd} to C:\Program Files (x86)\Mozilla Firefox\browser\extensions\{972ce4c6-7e08-4474-a285-3208198ce6fd}
1440019761813	addons.xpi	DEBUG	Skipping unavailable install location app-system-share
1440019761813	addons.xpi	DEBUG	Skipping unavailable install location app-system-local
1440019761814	addons.xpi	INFO	Mapping [e-mail] to C:\Program Files (x86)\Symantec\VIP Access Client
1440019761814	addons.xpi	DEBUG	checkForChanges
1440019761815	addons.xpi	DEBUG	Loaded add-on state from prefs: {"app-global":{"{82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}":{"d":"C:\\Program Files (x86)\\Mozilla Firefox\\browser\\extensions\\{82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}.xpi","e":false,"v":"7.3.16540.9015","st":1405376540000},"{972ce4c6-7e08-4474-a285-3208198ce6fd}":{"d":"C:\\Program Files (x86)\\Mozilla Firefox\\browser\\extensions\\{972ce4c6-7e08-4474-a285-3208198ce6fd}","e":true,"v":"40.0.2","st":1439606126309,"mt":1439606126073}},"winreg-app-global":{"[e-mail]":{"d":"C:\\Program Files (x86)\\Symantec\\VIP Access Client","st":1409677352568}}}
1440019761816	addons.xpi	DEBUG	getModTime: Recursive scan of {972ce4c6-7e08-4474-a285-3208198ce6fd}
1440019761817	addons.xpi	DEBUG	getInstallState changed: false, state: {"app-global":{"{82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}":{"d":"C:\\Program Files (x86)\\Mozilla Firefox\\browser\\extensions\\{82AF8DCA-6DE9-405D-BD5E-43525BDAD38A}.xpi","e":false,"v":"7.3.16540.9015","st":1405376540000},"{972ce4c6-7e08-4474-a285-3208198ce6fd}":{"d":"C:\\Program Files (x86)\\Mozilla Firefox\\browser\\extensions\\{972ce4c6-7e08-4474-a285-3208198ce6fd}","e":true,"v":"40.0.2","st":1439606126309,"mt":1439606126073}},"winreg-app-global":{"[e-mail]":{"d":"C:\\Program Files (x86)\\Symantec\\VIP Access Client","st":1409677352568}}}
1440019761818	addons.xpi	DEBUG	No changes found
1440019761823	addons.manager	DEBUG	Registering shutdown blocker for XPIProvider
1440019761823	addons.manager	DEBUG	Provider finished startup: XPIProvider
1440019761823	addons.manager	DEBUG	Starting provider: LightweightThemeManager
1440019761824	addons.manager	DEBUG	Registering shutdown blocker for LightweightThemeManager
1440019761824	addons.manager	DEBUG	Provider finished startup: LightweightThemeManager
1440019761824	addons.manager	DEBUG	Starting provider: GMPProvider
1440019761831	addons.manager	DEBUG	Registering shutdown blocker for GMPProvider
1440019761831	addons.manager	DEBUG	Provider finished startup: GMPProvider
1440019761831	addons.manager	DEBUG	Starting provider: PluginProvider
1440019761831	addons.manager	DEBUG	Registering shutdown blocker for PluginProvider
1440019761832	addons.manager	DEBUG	Provider finished startup: PluginProvider
1440019761832	addons.manager	DEBUG	Completed startup sequence
1440019761911	addons.xpi-utils	DEBUG	Starting async load of XPI database C:\Users\workvladan\AppData\Roaming\Mozilla\Firefox\Profiles\s8hnfj15.release2\extensions.json
1440019762085	addons.manager	DEBUG	Starting provider: <unnamed-provider>
1440019762085	addons.manager	DEBUG	Registering shutdown blocker for <unnamed-provider>
1440019762086	addons.manager	DEBUG	Provider finished startup: <unnamed-provider>
1440019762214	addons.xpi-utils	DEBUG	Async JSON file read took 0 MS
1440019762214	addons.xpi-utils	DEBUG	Finished async read of XPI database, parsing...
1440019762215	addons.xpi-utils	DEBUG	Successfully read XPI database
1440019762937	addons.manager	DEBUG	Starting provider: PreviousExperimentProvider
1440019762937	addons.manager	DEBUG	Registering shutdown blocker for PreviousExperimentProvider
1440019762938	addons.manager	DEBUG	Provider finished startup: PreviousExperimentProvider
downloadable font: kern: Too large subtable., table discarded (font-family: "Open Sans" style:normal weight:normal stretch:normal src index:1) source: https://mozorg.cdn.mozilla.net/media/fonts/OpenSans-Regular-webfont.woff mdn-min.css:1:27931
downloadable font: kern: Too large subtable., table discarded (font-family: "Open Sans Light" style:normal weight:normal stretch:normal src index:1) source: https://mozorg.cdn.mozilla.net/media/fonts/OpenSans-Light-webfont.woff mdn-min.css:1:26309
downloadable font: kern: Too large subtable., table discarded (font-family: "Open Sans Light" style:normal weight:bold stretch:normal src index:1) source: https://mozorg.cdn.mozilla.net/media/fonts/OpenSans-Regular-webfont.woff mdn-min.css:1:26835
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] 42869b6ed3
Key event not available on some keyboard layouts: key="r" modifiers="accel,alt" browser.xul
Key event not available on some keyboard layouts: key="c" modifiers="accel,alt" browser.xul
Key event not available on some keyboard layouts: key="i" modifiers="accel,alt,shift" browser.xul
1440019772921	Services.HealthReport.HealthReporter	WARN	Saved state file does not exist.
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] 8fba320c-3d97-44e7-8b1a-fe4ff5a8e3ce.png
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] VersionCheck.php
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] favicon.ico
GET 
https://versioncheck-dev.allizom.org/favicon.ico#-moz-resolution=16,16 [HTTP/1.1 404 Not Found 0ms]
1440019881922	DeferredSave.extensions.json	DEBUG	Save changes
1440019881922	DeferredSave.extensions.json	DEBUG	Starting timer
1440019881943	DeferredSave.extensions.json	DEBUG	Starting write
1440019881975	DeferredSave.extensions.json	DEBUG	Write succeeded
1440019881975	addons.xpi-utils	DEBUG	XPI Database saved, setting schema version preference to 17
DEPRECATION WARNING: FUEL is deprecated, you should use the add-on SDK instead.
You may find more details about this deprecation at: https://developer.mozilla.org/Add-ons/SDK/
jar:file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/browser/omni.ja!/components/fuelApplication.js 1458 Application
jar:file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/browser/omni.ja!/components/fuelApplication.js 726 af_ci
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js 1155 DebuggerObjectSupport.getProperties
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js 1059 getMatchedProps_impl
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js 1026 getMatchedPropsInDbgObject
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/utils.js 936 JSPropertyProvider
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js 82 makeInfallible/<
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webconsole.js 873 WCA_onAutocomplete
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js 1456 DSC_onPacket
resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js 561 LocalDebuggerTransport.prototype.send/<
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js 82 makeInfallible/<
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js 82 makeInfallible/<
null 0 null
 Deprecated.jsm:79:0

Comment 16

[Jorge Villalobos [:jorgev] (he/him)]

Okay, let's see what Kamil's test turns up.

Comment 17

[Jorge Villalobos [:jorgev] (he/him)]

Okay, so I found out what the problem was. The manifest had a maxVersion of 40.0.*, which is invalid on AMO, so I had to force its approval on staging. That made AMO drop all compatibility info, which is what caused the auto-update to fail. After fixing that, the auto-installation works.

I'm pushing to prod now. Kamil, I think we're good, but I would appreciate a quick test once I push this live.

Comment 18

[Jorge Villalobos [:jorgev] (he/him)]

The hotfix is signed and live on AMO.

Comment 19

[Kamil Jozwiak [:kjozwiak]]

Checking now :) Was actually testing while you pushed this as well. Noticed the same thing that Vladan mentioned and suddenly started working! Let me go through all the platforms and make sure it's working.

Comment 20

[Kamil Jozwiak [:kjozwiak]]

Went through verification using the following builds:
- http://archive.mozilla.org/pub/firefox/releases/40.0/
- http://archive.mozilla.org/pub/firefox/releases/40.0.2/

OS's:

* Windows 10 x64 -> PASSED (both fx40 & fx40.0.2)
* Win 8.1 x64 (VM) -> PASSED (both fx40 & fx40.0.2)
* OSX 10.10.5 x64 -> PASSED (both fx40 & fx40.0.2)
* Ubuntu 14.04.3 x64 (VM) -> PASSED (both fx40 & fx40.0.2)

Used the following steps:

- installed fx40/fx40.0.2
- checked about:config, dom.ipc.plugins.asyncInit;true
- changed extensions.logging.enabled;true, devtools.chrome.enabled;true,
- Pasted the following into the browser console:

var obj = {};
Cu.import("resource://gre/modules/AddonManager.jsm", obj);
obj.AddonManagerPrivate.backgroundUpdateCheck();

- checked about:config and ensured dom.ipc.plugins.asyncInit;false
- checked about:config and ensured extensions.hotfix.lastVersion;20150818.01
- restarted fx and ensured that the changes are still present

Comment 21

[Vladan Djeric (:vladan)]

Attachment: about:addons.png

I just tried this out on release Firefox 40.0.2, and I'm seeing some really weird stuff.

- The hotfix shows up in about:addons. Should it??
- Unsigned add-on blocking is turned on in Release 40. I thought this was holding on Beta 41?

Comment 22

[Vladan Djeric (:vladan)]

Attachment: Browser console log.txt

Comment 23

[Dave Townsend [:mossop]]

(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #21)
> Created attachment 8650254 [details]
> about:addons.png
> 
> I just tried this out on release Firefox 40.0.2, and I'm seeing some really
> weird stuff.
> 
> - The hotfix shows up in about:addons. Should it??

Yes, hotfixes have always been visible in the add-ons manager.

> - Unsigned add-on blocking is turned on in Release 40. I thought this was
> holding on Beta 41?

Blocking isn't expected, we should warn about unsigned add-ons though. The prefs in release look set correctly: https://hg.mozilla.org/releases/mozilla-release/annotate/tip/browser/app/profile/firefox.js#l75 and things look fine in my local release build. This sounds like something unrelated to the hotfix though, can you please file?

Comment 24

[Kamil Jozwiak [:kjozwiak]]

> Yes, hotfixes have always been visible in the add-ons manager.

Strange... I went through the same steps I used in comment #20 just to double check but the hotfix never appears under about:addons, at least for me. I checked all the categories (Extensions, Appearances, Plugins, Services) and restarted fx several times. The change is being listed in about:support under the "Important Modified Preferences" category but I'm not seeing it under about:addons. Unless I'm looking in the wrong area??

* OSX 10.10.5 x64 -> hotfix didn't appear under about:addons
* 2 x Win 10 x64 -> hotfix didn't appear under about:addons
* 2 x Win 8.1 x64 -> hotfix didn't appear under about:addons
* Ubuntu 14.04.3 x64 -> hotfix didn't appear under about:addons

I remotely connected to a machine that has a fairly old profile and triggered the hotfix manually but it didn't appear under about:addons. I also tried it on my fiancee machine and got the same result.

Should I be seeing the hotfix under about:addons?

Comment 25

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #24)
> Should I be seeing the hotfix under about:addons?

My expectation (and experience when I tested the unsigned hotfix locally) was that the addon immediately removed itself after executing. That is also what the MDN document says [1]:

> Test that the hotfix uninstalls itself after completing its task. Most of the hotfixes we've shipped so far performs an immediate task and uninstalls itself right afterwards, but there were some exceptions where it needs to remain installed until certain conditions are met.

[1] https://developer.mozilla.org/en-US/Add-ons/Hotfix

Comment 26

[Vladan Djeric (:vladan)]

The hotfix add-on did indeed disappear after a while.

Kamil/Aaron/Mossop: can you try installing Skype click-to-call and see if it gets blocked in about:addons for being unsigned in Release Firefox?

http://www.skype.com/en/download-skype/click-to-call/

Comment 27

[Kamil Jozwiak [:kjozwiak]]

> My expectation (and experience when I tested the unsigned hotfix locally)
> was that the addon immediately removed itself after executing.

That's what I'm seeing as well, the "Firefox Asynchronous Plugin Initialization Hotfox" entry appears under "Extensions" and disappears. If you're viewing the "Extensions" category while the hotfix is installed, it will be visible until you refresh about:addons or simply click on another category and go back into "Extensions".

> Kamil/Aaron/Mossop: can you try installing Skype click-to-call and see if it
> gets blocked in about:addons for being unsigned in Release Firefox?

When I installed the click-to-call extension, it initially appears disabled and opens a "Warning" tab when you restart fx. You can enable the extension by either selecting "Allow this installation" and clicking continue via the warning tab or you can simply click "Enable" next to the extension under about:addons. The extension does display the "Skype Click to Call could not be verified for use in Firefox. Proceed with caution."

I tried all of the above with both fx40 and fx40.0.2 with Win 10 x64, Win 8.1 x64 and Win 7 x64.

Comment 28

[Dave Townsend [:mossop]]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #24)
> > Yes, hotfixes have always been visible in the add-ons manager.
> 
> Strange... I went through the same steps I used in comment #20 just to
> double check but the hotfix never appears under about:addons, at least for
> me. I checked all the categories (Extensions, Appearances, Plugins,
> Services) and restarted fx several times. The change is being listed in
> about:support under the "Important Modified Preferences" category but I'm
> not seeing it under about:addons. Unless I'm looking in the wrong area??

Sorry I should have been clearer, if the hotfix chooses to remain installed then it will show up in the add-ons manager and so you can sometimes see it there briefly even if it uninstalls itself.

(In reply to Kamil Jozwiak [:kjozwiak] from comment #27)
> > Kamil/Aaron/Mossop: can you try installing Skype click-to-call and see if it
> > gets blocked in about:addons for being unsigned in Release Firefox?
> 
> When I installed the click-to-call extension, it initially appears disabled
> and opens a "Warning" tab when you restart fx. You can enable the extension
> by either selecting "Allow this installation" and clicking continue via the
> warning tab or you can simply click "Enable" next to the extension under
> about:addons. The extension does display the "Skype Click to Call could not
> be verified for use in Firefox. Proceed with caution."

This is what I see too and what I would expect. Vladan if you're still seeing problems please file another bug so we can dig into it without cluttering up this bug.

Comment 29

[Vladan Djeric (:vladan)]

Filed bug 1196846 for the blocked-on-Release issue

Comment 30

[Kamil Jozwiak [:kjozwiak]]

Marking as verified as per comment # 20 & comment # 24.