1196885 - [Contacts] Editing a contact will leave the Contacts in a buggy state: orientation may rotate to landscape

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150820_1243.txt

Description:
When the user finishes editing a contact, they will observe the Contacts app exhibit buggy behavior. The app may now rotate to landscape, and the status bar will have lost it's theme color (communications blue, becoming settings gray). Returning to contacts listing will restore the theme color of status bar, but app may still be rotated to landscape. Opening the app in card view, or closing + re-opening will remove the landscape orientation potential.

Repro Steps:
1) Update a Aries to 20150820012109
2) Open Contacts app
3) Create a new contact {First Name, Last Name, Phone Number}
4) Edit contact from step-3: change {First Name}

Actual:
1) Phone may now be rotated to landscape within app (card-view or restarting app revokes this behavior)
2) Status bar changes theme color while in contact details. 

Expected:
Contact is edited, state of app remains unchanged with no additional behavior


Environmental Variables:
--------------------------------

Device: Aries 2.5
Build ID: 20150820012109
Gaia: 89e0096a3de0378e3eda77e6a2a0bb5ca03eb8bb
Gecko: 29b2df16e961fbe9a379362ecba6f888d1754bc3
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.5
BuildID: 20150820030207
Gaia: 89e0096a3de0378e3eda77e6a2a0bb5ca03eb8bb
Gecko: 29b2df16e961fbe9a379362ecba6f888d1754bc3
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
***************************

Issue DOES NOT REPRODUCE on 2.2 for flame devices
Results: Contact is edited, state of app remains unchanged with no additional behavior

Device: Flame 2.2
BuildID: 20150820032506
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: ebaa55c4247b
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------


Repro frequency: 5/5
See attached: 
video
logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Regression. Let's get a window here.

Comment 2

[Martin Shuman [:Marty]]

I found the regression window for the landscape issue, but this is not the same window as the status bar issue.  I've amended the title to specify this bug as the landscape issue, and the status bar issue will be written up in a separate bug.

This issue appears to be caused by:
Bug 1131470 - w3c screen orientation api has changed

Mozilla-inbound Regression Window:

Last Working 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150819042439
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: 4203e86db40a2fdcc52fa2f6ca263a1d9d704b91
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150819041446
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: be65c38abed995c7975383836c87df21ac02bcc7
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working gaia / First Broken gecko - Issue DOES reproduce
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: be65c38abed995c7975383836c87df21ac02bcc7

First Broken gaia / Last Working gecko - Issue does NOT reproduce
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: 4203e86db40a2fdcc52fa2f6ca263a1d9d704b91

Gecko Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4203e86db40a2fdcc52fa2f6ca263a1d9d704b91&tochange=be65c38abed995c7975383836c87df21ac02bcc7

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

William the changes for bug 1131470 seem to have caused this issue, can you take a look?

Comment 4

[Mahendra Potharaju [:mahe]]

Breaking a basic functionality to updating contacts. Blocking 2.5

Comment 5

[Martin Shuman [:Marty]]

Status bar issue has been written up separately in Bug 1196954

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Borja I think this is caused by the new work landed can you take a look? Or find someone that can :)

Comment 7

[Borja Salguero [:borjasalguero]]

I think this is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1131470#c40. I've tried Gaia master with an old Gecko build for Aries (a build 3 days old) and I can not reproduce this.

Could you check if this is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1131470#c40? This 'orientation' is not related with Contacts, and seems to be a bug system wide. Thanks!

Comment 8

[William Chen [:wchen]]

The fix I have in bug 1196290 should also fix this issue.

Comment 9

[Oliver Nelson [:oliverthor]]

Adding qawanted tag as I won't be able to attend to this issue.

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Borja Salguero [:borjasalguero] from comment #7)
> Could you check if this is due to
> https://bugzilla.mozilla.org/show_bug.cgi?id=1131470#c40? This 'orientation'
> is not related with Contacts, and seems to be a bug system wide. Thanks!

As the regression window at comment 2 pointed out, this is due to changes made in bug 1131470. The effect of that fallout may be system wide but so far we've only found this bug as a fallout from bug 1131470.

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

I cannot reproduce this one with latest master. Please, reopen if you can.