1197228 - Transparent BrowserSearch when searching on Android 2.3 phone when web content is in background

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: IMG_20150821_164702~2.jpg

When searching on my Android 2.3 phone (HTC Desire HD) the search background is missing and you can see the website you have been visiting before (see attached screenshot).

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Ioana please check if any of the SV devices repo this bug.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I removed the background as part of the search engine bar work (bug 1137483, landed in 41) – I guess I screwed up the styles. iirc, each item in the list should set it's own background color.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

NI self to investigate.

Comment 4

[Catalin Suciu [:csuciu]]

I'm able to reproduce on latest Nightly on HTC Desire HD (2.3.5) and HTC Desire S (2.3.3)

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I can reproduce. Notably, it does not repro with about:home – just web content.

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

Ioana would the SV team find a rough regression range. Just the affected versions, no need to deep dive with mozregression.

Comment 8

[Teodora Vermesan (:TeoVermesan)]

19-08 build: not affected
20-08 build: affected

pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f384789a29dcfd514d25d4a16a97ec5309612d78&tochange=29b2df16e961fbe9a379362ecba6f888d1754bc3

Comment 9

[Ioana Chiorean]

Thanks Teodora for working on this one!

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The only thing that stands out to me here is bug 1180295, the dynamic toolbar rewrite. Kats, any ideas if it might have affected this bug and how?

Comment 11

[Kartikaya Gupta (email:[e-mail])]

I guess it's possible that bug 1180295 exposed this but it feels more like a pre-existing bug to me. None of my patches touched that view at all and also didn't fiddle with any view backgrounds.

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sorry, I should have provided more context.

When we show BrowserSearch (i.e. click urlbar and start typing), we set the window's background drawable to white [1] to prevent graphical glitches from hiding the keyboard and the views on top of it are transparent in order to prevent overdraw. When BrowserSearch is hidden, we set the window's background drawable to null.

Presumably, the window's background drawable is not being set (or is being changed) on 2.3 devices – maybe it's an Android fragmentation discrepancy.

Kats, did you make any changes regarding the window's background drawable?

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java?rev=1c77317dd842#2811

Comment 13

[Kartikaya Gupta (email:[e-mail])]

(In reply to Michael Comella (:mcomella) from comment #12)
> Kats, did you make any changes regarding the window's background drawable?

As far as I know I didn't touch any of this code.

> [1]:
> https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/
> BrowserApp.java?rev=1c77317dd842#2811

I borrowed a Gingerbread device and can reproduce this bug. Adding some logging at this line of code shows that it is still getting hit as one would expect. So either it's not working (the Android fragmentation discrepancy you mentioned?) or the problem is elsewhere...

Comment 14

[Kartikaya Gupta (email:[e-mail])]

I confirmed that this was caused by my patches; the bisection seemed to point to https://hg.mozilla.org/integration/mozilla-inbound/rev/b675e378dadf although that doesn't really make much sense. I'll dig into it.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

The patches I posted to bug 1197811 seem to fix this as well.