Closed Bug 1197412 Opened 9 years ago Closed 9 years ago

Move drawableTintList functionality to ThemedImage*

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

MozReview Request: Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian
40 bytes, text/x-review-board-request
sebastian
: review+
Details 
It's a reimplementation of android:tintList and is useful for all Image* views.

bug 1197014 landed before and touches the same files so adding to deps. Needed to simplify bug 1148550.
Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian

Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.
Attachment #8651283 - Flags: review?(s.kaspari)
Comment on attachment 8651283 [details]
MozReview Request: Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian

Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian

Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.

Additionally, fix a bug about using android:tint when drawableTintList was not
used.
Attachment #8651283 - Flags: review?(s.kaspari) → review+
Comment on attachment 8651283 [details]
MozReview Request: Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian

https://reviewboard.mozilla.org/r/16891/#review15103

Ship It!
url:        https://hg.mozilla.org/integration/fx-team/rev/86782173d9b84f58982db4f5ccb81290e113caba
changeset:  86782173d9b84f58982db4f5ccb81290e113caba
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Fri Aug 21 18:05:33 2015 -0700
description:
Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian

Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.

Additionally, fix a bug about using android:tint when drawableTintList was not
used.
https://hg.mozilla.org/mozilla-central/rev/86782173d9b8
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: