Closed
Bug 1197412
Opened 10 years ago
Closed 10 years ago
Move drawableTintList functionality to ThemedImage*
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
It's a reimplementation of android:tintList and is useful for all Image* views.
bug 1197014 landed before and touches the same files so adding to deps. Needed to simplify bug 1148550.
|
Assignee | |
Comment 1•10 years ago
|
||
Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian
Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.
Attachment #8651283 -
Flags: review?(s.kaspari)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8651283 [details]
MozReview Request: Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian
Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian
Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.
Additionally, fix a bug about using android:tint when drawableTintList was not
used.
|
||
Updated•10 years ago
|
Attachment #8651283 -
Flags: review?(s.kaspari) → review+
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8651283 [details]
MozReview Request: Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian
https://reviewboard.mozilla.org/r/16891/#review15103
Ship It!
|
|
Assignee | |
Comment 4•10 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/86782173d9b84f58982db4f5ccb81290e113caba
changeset: 86782173d9b84f58982db4f5ccb81290e113caba
user: Michael Comella <michael.l.comella@gmail.com>
date: Fri Aug 21 18:05:33 2015 -0700
description:
Bug 1197412 - Move drawableTintList to ThemedImage*. r=sebastian
Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.
Additionally, fix a bug about using android:tint when drawableTintList was not
used.
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•