1197413 - Remove foreground drawable's setColorFilter in BrowserToolbarTabletBase.setPrivateMode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

And replace it with setPrivateMode with colorStateLists.

bug 1197412 implemented the appropriate functionality for this.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I can't remove colorFilters from everything because we don't have support for backgroundTintLists, which the TabCounters use to display their content. I filed bug 1197432 to support backgroundTintList.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1197413 - Switch setColorFilter to setPrivateMode in tablet toolbar. r=sebastian

Bug 1197413 - Switch setColorFilter to setPrivateMode in tablet toolbar. r=sebastian

This patch has a side effect of changing the color of the forward
button as it animates forward and back, but it's minimal enough
that I'm okay with it, and it cleans up disabled/private state color
management (particularly after the following patch).

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1197413 - Don't change alpha when disabling tablet nav buttons. r=sebastian

Bug 1197413 - Don't change alpha when disabling tablet nav buttons. r=sebastian

The enabled/disabled colors are set via ColorStateLists so the alpha
is unnecessary.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8651312 [details]
MozReview Request: Bug 1197413 - Switch setColorFilter to setPrivateMode in tablet toolbar. r=sebastian

https://reviewboard.mozilla.org/r/16907/#review15105

Ship It!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8651313 [details]
MozReview Request: Bug 1197413 - Don't change alpha when disabling tablet nav buttons. r=sebastian

https://reviewboard.mozilla.org/r/16909/#review15107

Ship It!

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/e1738296ea5fb7109d404b04a57e031bd3b6e23f
changeset:  e1738296ea5fb7109d404b04a57e031bd3b6e23f
user:       Michael Comella <[e-mail]>
date:       Fri Aug 21 17:10:30 2015 -0700
description:
Bug 1197413 - Switch setColorFilter to setPrivateMode in tablet toolbar. r=sebastian

This patch has a side effect of changing the color of the forward
button as it animates forward and back, but it's minimal enough
that I'm okay with it, and it cleans up disabled/private state color
management (particularly after the following patch).

url:        https://hg.mozilla.org/integration/fx-team/rev/238b8417cf2a5a8d97db20faaf5df456b14f30be
changeset:  238b8417cf2a5a8d97db20faaf5df456b14f30be
user:       Michael Comella <[e-mail]>
date:       Fri Aug 21 17:17:24 2015 -0700
description:
Bug 1197413 - Don't change alpha when disabling tablet nav buttons. r=sebastian

The enabled/disabled colors are set via ColorStateLists so the alpha
is unnecessary.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1738296ea5f
https://hg.mozilla.org/mozilla-central/rev/238b8417cf2a