Closed Bug 1198127 Opened 7 years ago Closed 2 months ago

Garbage collection markers should be real markers

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: vporof, Unassigned)

References

Details

(Whiteboard: [polish-backlog] [difficulty=hard])

Right now they're faked on the js land in timeline.js. I don't see a real reason why this is the case, and makes my marker data compacting efforts a bit harder.
Y DIS UNREAL?
Flags: needinfo?(jsantell)
Because its from Debugger.Memory is my understanding
Flags: needinfo?(jsantell) → needinfo?(nfitzgerald)
The onGarbageCollection hook has dual purposes: first, it provides a sense of time for the allocations log, and second we can use it to create GC markers. It would be fine to use AutoTimelineMarker or whatever for the second purpose and have the onGarbageCollection hook only for the first. It would require a TimelineMarker subclass to attach the gc reason and whether it is non-incremental or not. Also the gc number, after bug 1197970. I think this is possible from inside SpiderMonkey, but I always forget how the interactions with the profiler work from inside the engine.
Flags: needinfo?(nfitzgerald)
Markers can be created whenever now, lazily, as long as we have timestamps. We're not forced to create them exactly where the marked code in question is being executed.
Blocks: 1194297
Whiteboard: [polish-backlog] [difficulty=hard]
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P3
Product: Firefox → DevTools

Now that we replaced the old performance panel by the Firefox Profiler (see Bug 1668219) we're closing bugs related to this.

Filter on MASSCLOSEOLDPERFTOOLBUGS.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.