Garbage collection markers should be real markers

NEW
Unassigned

Status

P3
normal
3 years ago
3 months ago

People

(Reporter: vporof, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-backlog] [difficulty=hard])

(Reporter)

Description

3 years ago
Right now they're faked on the js land in timeline.js. I don't see a real reason why this is the case, and makes my marker data compacting efforts a bit harder.
(Reporter)

Comment 1

3 years ago
Y DIS UNREAL?
Flags: needinfo?(jsantell)
Because its from Debugger.Memory is my understanding
Flags: needinfo?(jsantell) → needinfo?(nfitzgerald)
The onGarbageCollection hook has dual purposes: first, it provides a sense of time for the allocations log, and second we can use it to create GC markers. It would be fine to use AutoTimelineMarker or whatever for the second purpose and have the onGarbageCollection hook only for the first. It would require a TimelineMarker subclass to attach the gc reason and whether it is non-incremental or not. Also the gc number, after bug 1197970. I think this is possible from inside SpiderMonkey, but I always forget how the interactions with the profiler work from inside the engine.
Flags: needinfo?(nfitzgerald)
(Reporter)

Comment 4

3 years ago
Markers can be created whenever now, lazily, as long as we have timestamps. We're not forced to create them exactly where the marked code in question is being executed.
(Reporter)

Updated

3 years ago
Blocks: 1194297
Whiteboard: [polish-backlog] [difficulty=hard]
(Reporter)

Comment 5

3 years ago
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P3

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.