1198286 - Visual adjustments to about:privatebrowsing

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[:Paolo Amadini]

This bug is for the part of the work in bug 1195270 that does not require string changes and can be uplifted to Firefox 42 more easily.

Comment 1

[:Paolo Amadini]

Attachment: MozReview Request: Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

Comment 2

[:Paolo Amadini]

Summary of changes:
- Smaller page header text that resizes proportionally
- Less margin between bold headers and lists
- More space between lists
- Tour button extends to the full width of the section

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: with-patch-applied.png

Ash, what do you think about the changes?  Screenshot here is with the patch applied, and you can compare that with a current Nightly private window.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8652351 [details]
MozReview Request: Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

https://reviewboard.mozilla.org/r/17129/#review15295

Code changes are fine with me as long as Ash signs off

Comment 5

[Ash Grigas]

(In reply to Brian Grinstead [:bgrins] from comment #4)
> Comment on attachment 8652351 [details]
> MozReview Request: Bug 1198286 - Visual adjustments to
> about:privatebrowsing. r=bgrins
> 
> https://reviewboard.mozilla.org/r/17129/#review15295
> 
> Code changes are fine with me as long as Ash signs off

looks good to me!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f311841a6ad8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f311841a6ad8

Comment 8

[:Paolo Amadini]

Comment on attachment 8652351 [details]
MozReview Request: Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

Approval Request Comment
[Feature/regressing bug #]: New about:privatebrowsing landing page
[User impact if declined]: Sub-optimal design on a very visible page
[Describe test coverage new/current, TreeHerder]: Landed on m-c
[Risks and why]: Low, only small visual changes.
[String/UUID change made/needed]: None

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8652351 [details]
MozReview Request: Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

Improve the UX of a new feature, taking it.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/af82d216ded7

Comment 11

[Paul Silaghi, QA [:pauly]]

Verified fixed 43.0a1 (2015-08-30) Win 7

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 42.0a2 (2015-09-02) Win 7