Closed Bug 1198286 Opened 4 years ago Closed 4 years ago

Visual adjustments to about:privatebrowsing

Categories

(Firefox :: Private Browsing, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 43
Iteration:
43.2 - Sep 7
Tracking Status
firefox42 --- verified
firefox43 --- verified

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(2 files)

This bug is for the part of the work in bug 1195270 that does not require string changes and can be uplifted to Firefox 42 more easily.
Flags: qe-verify+
Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins
Attachment #8652351 - Flags: review?(bgrinstead)
Iteration: --- → 43.2 - Sep 7
Summary of changes:
- Smaller page header text that resizes proportionally
- Less margin between bold headers and lists
- More space between lists
- Tour button extends to the full width of the section
Attached image with-patch-applied.png
Ash, what do you think about the changes?  Screenshot here is with the patch applied, and you can compare that with a current Nightly private window.
Attachment #8652555 - Flags: ui-review?(agrigas)
Attachment #8652351 - Flags: review?(bgrinstead) → review+
Comment on attachment 8652351 [details]
MozReview Request: Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

https://reviewboard.mozilla.org/r/17129/#review15295

Code changes are fine with me as long as Ash signs off
(In reply to Brian Grinstead [:bgrins] from comment #4)
> Comment on attachment 8652351 [details]
> MozReview Request: Bug 1198286 - Visual adjustments to
> about:privatebrowsing. r=bgrins
> 
> https://reviewboard.mozilla.org/r/17129/#review15295
> 
> Code changes are fine with me as long as Ash signs off

looks good to me!
Attachment #8652555 - Flags: ui-review?(agrigas) → ui-review+
No longer blocks: 1188565
https://hg.mozilla.org/mozilla-central/rev/f311841a6ad8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
QA Contact: paul.silaghi
Comment on attachment 8652351 [details]
MozReview Request: Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

Approval Request Comment
[Feature/regressing bug #]: New about:privatebrowsing landing page
[User impact if declined]: Sub-optimal design on a very visible page
[Describe test coverage new/current, TreeHerder]: Landed on m-c
[Risks and why]: Low, only small visual changes.
[String/UUID change made/needed]: None
Attachment #8652351 - Flags: approval-mozilla-aurora?
Comment on attachment 8652351 [details]
MozReview Request: Bug 1198286 - Visual adjustments to about:privatebrowsing. r=bgrins

Improve the UX of a new feature, taking it.
Attachment #8652351 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed 43.0a1 (2015-08-30) Win 7
Status: RESOLVED → VERIFIED
Verified fixed FF 42.0a2 (2015-09-02) Win 7
You need to log in before you can comment on or make changes to this bug.