If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove hardcoded fonts in about:privatebrowsing

VERIFIED FIXED in Firefox 42

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: ntim, Assigned: jaws)

Tracking

unspecified
Firefox 43
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox42 verified, firefox43 verified)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The `font: message-box` rule inside common.css handles system fonts fine.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1190427#c46
Created attachment 8646984 [details] [diff] [review]
Patch

As :ntim pointed out, font:message-box is already present on the page and it causes the system's UI font to be used. This bug is very noticeable on Windows, where we are now showing Arial when Segoe UI should be used.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8646984 - Flags: review?(paolo.mozmail)

Updated

2 years ago
Attachment #8646984 - Flags: review?(paolo.mozmail) → review+
Keywords: checkin-needed

Comment 2

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/6bf22f3dd1cf
Keywords: checkin-needed

Comment 3

2 years ago
Actually, in order to be be able to adjust the layout for different languages, this page includes localizable widths that are set so that content doesn't wrap. The right width depends on the font metrics.

In the current setup, if localizers have already determined the right width for the old font, the effect with the new font might be incorrect I've checked that in English on OS X 10.9 the Tracking Protection state indicator is now on the next line. In this new situation where we have fonts with different metrics, we could maybe redefine the layout so that those widths are determined automatically, or at least the layout won't break - I'll try to see if this can be done while working on the redesign in bug 1192625, which we plan to uplift anyways.

The alternative is just to rename the entities with the width so that localizers will check them a second time, similarly to what we did for the strings in bug 1192621, but it's unlikely we can uplift those changes to the Developer Edition channel.
https://hg.mozilla.org/mozilla-central/rev/6bf22f3dd1cf
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
(Reporter)

Comment 5

2 years ago
Can this be uplifted to Aurora ?
Flags: needinfo?(jaws)

Comment 6

2 years ago
(In reply to Tim Nguyen [:ntim] (mostly away until 26 August) from comment #5)
> Can this be uplifted to Aurora ?

Not until we've fixed the layout regressions this caused, which will be done in bug 1195270.
Blocks: 1195270
Flags: needinfo?(jaws)
Comment on attachment 8646984 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug  1190427
[User impact if declined]: ugly styling for private browsing page on Windows
[Describe test coverage new/current, TreeHerder]: visual change only
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8646984 - Flags: approval-mozilla-aurora?
Attachment #8646984 - Flags: approval-mozilla-aurora?
Flags: needinfo?(jaws)

Updated

2 years ago
Blocks: 1198286
No longer blocks: 1195270
Flags: needinfo?(jaws)
Flags: needinfo?(jaws)

Updated

2 years ago
Blocks: 1198287

Comment 8

2 years ago
This can be uplifted, but I'd like to see the outcome of the discussion in bug 1198287 first.

We also have other style changes in the queue and it may be better to uplift everything in one block.

Comment 9

2 years ago
Comment on attachment 8646984 [details] [diff] [review]
Patch

Ready to be uplifted now that we have defined the approach in bug 1199644.

Approval Request Comment
[Feature/regressing bug #]: New about:privatebrowsing landing page
[User impact if declined]: Sub-optimal design on a very visible page
[Describe test coverage new/current, TreeHerder]: Landed on mozilla-central
[Risks and why]: Limited to the page
[String/UUID change made/needed]: None
Attachment #8646984 - Flags: approval-mozilla-aurora?

Updated

2 years ago
Blocks: 1195270
Flags: qe-verify+
Whiteboard: [fxprivacy]

Updated

2 years ago
Flags: needinfo?(jaws)

Updated

2 years ago
Iteration: --- → 43.1 - Aug 24
Priority: -- → P2
status-firefox42: --- → affected
Comment on attachment 8646984 [details] [diff] [review]
Patch

Improve the UX, taking it.
Attachment #8646984 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/ccc605b24364
status-firefox42: affected → fixed
Verified fixed 42.0a2 (2015-09-10), 43.0a1 (2015-09-10) Win 7
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
status-firefox43: fixed → verified

Updated

2 years ago
Priority: P2 → P1
You need to log in before you can comment on or make changes to this bug.