1199191 - firefox_ui_updates.py script should use `abs_work_dir` as workspace folder

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The mozharness scripts are using a build folder to put everything in what is related to the run. What I can see is that we install the build to /tmp, and because of bug 1199184 we do not clean-it up correctly. If the installed binary would be located under build we would have more control over it.

Comment 1

[Armen [:armenzg]]

We clean up at the beginning of the next run IIRC.
That means we should make sure nothing is left behind running from there.

Perhaps we should also clean up post script and have a flag to prevent that when running on a developer's machine.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, I will have a look at this and check how other scripts handling the clean-up of the workspace.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, so the thing is that we internally call the firefox-ui-tests command and passing in the installer path. And that installs it to the temporary location. Given that also every other data like profiles end-up in /tmp I'm tempted to add a new command line option for firefox-ui-tests, which allows to specify a workspace (build) folder, which will take it as root for every data which is getting created.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Once bug 1199574 is fixed we can make use of the --workspace option to tell that all data has to be created in the build folder.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: mozharness_builddir v1

Comment 6

[Armen [:armenzg]]

Comment on attachment 8654876 [details] [diff] [review]
mozharness_builddir v1

Review of attachment 8654876 [details] [diff] [review]:
-----------------------------------------------------------------

Feel free to land now or later with DONTBUILD or NPOTB.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/749cf956cbf4

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/749cf956cbf4