1200098 - update graphite2 library to upstream release 1.3.2

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[martin_hosken]

This release of graphite2 replaces 1.3.0. It fixes all the fuzz bugs you and we have found and resolves some bidi issues.

Comment 1

[Jonathan Kew [:jfkthame]]

Tryserver says we hit a (bidi-related) crash in one of our reftests:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f5e1475fd83

So we'll need to resolve that before taking an update here.

Comment 2

[martin_hosken]

when you call gr_make_seg try oring the rtl parameter with 2. Since your strings are all monodirectional, no point in running full bidi on them. Having said that, there may well be a bug since in theory whether you run full bidi or not on a monodirectional string shouldn't make any difference.

Comment 3

[Jonathan Kew [:jfkthame]]

(In reply to martin_hosken from comment #2)
> when you call gr_make_seg try oring the rtl parameter with 2. Since your
> strings are all monodirectional, no point in running full bidi on them.
> Having said that, there may well be a bug since in theory whether you run
> full bidi or not on a monodirectional string shouldn't make any difference.

I tried this but it still hits the crash.

Comment 4

[Jonathan Kew [:jfkthame]]

Note that the crash occurs on a (diacritic-only) segment that we're shaping with dir=ltr (because diacritics inherit their direction from the base character), while aSilf->dir() is rtl. So it still ends up calling seg->reverseSlots().

Comment 5

[martin_hosken]

Untested fix in repo (well it doesn't crash in normal cases, but not tested against your test case).

In addition. The copyright message that had to be added for 1.3.0 has been removed and all files have the same license and copyright. So that patch can be removed.

Comment 6

[Jonathan Kew [:jfkthame]]

Release 1.3.2 is now out; we should go ahead and update. (This is primarily about bug-fixing and robustness, following an intensive fuzz-testing period.)

Comment 7

[Jonathan Kew [:jfkthame]]

Attachment: Update graphite2 library to release 1.3.2 from upstream

Comment 8

[Jonathan Kew [:jfkthame]]

Attachment: patch 2 - Remove the data-shrinker copyright notice that was added for graphite 1.3.0; no longer present in release 1.3.2

Upstream has modified their code such that it no longer carries this additional copyright, so we can remove it from about:license per comment 5 above.

Comment 9

[Jonathan Kew [:jfkthame]]

Attachment: patch 3 - Pass the gr_nobidi flag when shaping with graphite2, as we split text into unidirectional runs ahead of time

This is just a minor tweak for efficiency; we ought to have been doing this all along. There should be no effect on behavior.

Comment 10

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f69b26c655c

Comment 11

[Gervase Markham [:gerv]]

Comment on attachment 8658671 [details] [diff] [review]
patch 2 - Remove the data-shrinker copyright notice that was added for graphite 1.3.0; no longer present in release 1.3.2

Review of attachment 8658671 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv; thanks for coming back and cleaning up :-)

Gerv

Comment 12

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e3c7c4b60893bda2d2eae7fcd2aa2bab64c04c8
Bug 1200098 - Update graphite2 library to release 1.3.2 from upstream. r=jdaggett

https://hg.mozilla.org/integration/mozilla-inbound/rev/66e7e47e3144da359a8d0e0e4ebfa4d12d33840a
Bug 1200098 - patch 2 - Remove the data-shrinker copyright notice that was added for graphite 1.3.0; no longer present in release 1.3.2. r=gerv

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca6aca7378307f47d5807f4d40ad5f27cd67babf
Bug 1200098 - patch 3 - Pass the gr_nobidi flag when shaping with graphite2, as we split text into unidirectional runs ahead of time. r=jdaggett

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5e3c7c4b6089
https://hg.mozilla.org/mozilla-central/rev/66e7e47e3144
https://hg.mozilla.org/mozilla-central/rev/ca6aca737830