951009 - update graphite2 library to release 1.2.4

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[martin_hosken]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131206152142

Steps to reproduce:

This page is used for testing: http://lists.freedesktop.org/archives/harfbuzz/attachments/20131216/52f829d9/attachment-0001.html and it shows that for Graphite enabled the fonts are not catching the language information. This is a known bug in the graphite2 engine which was fixed in the recent 1.2.4 release.

I propose we take v1.2.4 of graphite2 engine into the earliest sensible release in the release path (beta probably, but perhaps even aurora).

Comment 1

[Jonathan Kew [:jfkthame]]

Hmm.... The page mentioned actually has incorrect language tags; they should be lang="ur" and "sd", not "urd" and "snd". On further testing, I'm seeing that with the tags corrected, it does show the expected language-dependent forms under Graphite shaping. (But not OpenType, due to a bug in the current Scheherazade font.)

So it looks like this does work in current Nightly. (At least some of the time?)

We should still take the gr2 update, to stay in sync with upstream, but it may not be essential for the lang-tagging support; my initial testing as mentioned on the HB list was just wrong, I think.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: update graphite2 library to upstream v1.2.4

Comment 3

[Jonathan Kew [:jfkthame]]

Tryserver thinks this'll be OK: https://tbpl.mozilla.org/?tree=Try&rev=99e5f141d1af

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: graphite 1.2.4 patch generated with -w (ignore space) option

Upstream has replaced a lot of <tab>s with spaces, which makes the patch here look awfully big. For reference, here's a version of the diff with the -w option, so it only shows "real" changes.

See http://projects.palaso.org/projects/graphitedev/repository for the upstream mercurial log, individual changesets, etc.

Comment 5

[John Daggett (:jtd)]

Comment on attachment 8348850 [details] [diff] [review]
update graphite2 library to upstream v1.2.4

Looks fine. Would be nice if the white-space swizzling was in a separate patch but, meh...

Comment 6

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4d9bd399020

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d4d9bd399020