1200228 - Content is perma-fuzzy when zoomed in

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

STR on a Nexus 4 (will probably work on other devices with similar screen resolutions/densities):

1. Load the page in the URL field
2. Zoom in to the max
3. Scroll to the right as far as you can go

Expected: content renders fine

Actual: right side of the content is blurry/missing, and remains that way permanently.

This regressed between the nightlies of the 28th and 29th, this is the regression range I have:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=87e23922be375985d0b1906ed5ba5f095f323a38&tochange=7db14bebae9196d780b1d64d2fd32d1bda26828b

I'm suspecting bug 1191539 for now but I'll confirm with inbound builds.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Inbound regression window:

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1af3359b7d57b4a0a0afcaa641fccb2d87ed5589&tochange=16c530a7412e0266639fe025cd16730c0d29a391

BenWa, I'm still suspecting it's bug 1191539 but I guess it could also be the backout you landed for the other bug. Can you take a look?

Comment 2

[Benoit Girard (:BenWa)]

It must be bug 1191539. I imagine we were relying on this broken behavior to trigger a paint. We need to get a proper paint triggered for zooming then.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

This is an example of what it looks like

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Note that it's not necessarily upon zooming that the issue happens. I can scroll up and down in this state and it triggers repaints, but the right side is still garbage. It's almost like the displayport adjustment isn't accounting for the resolution properly and so it's always off when zoomed in.

Comment 5

[Benoit Girard (:BenWa)]

Ahh, then perhaps it's the ForceInside that needs adjusting. I'll look into this right away.

Comment 6

[Benoit Girard (:BenWa)]

I can't get a build up because of bug 1200335.

Comment 8

[Benoit Girard (:BenWa)]

[Tracking Requested - why for this release]: Severe regression. We shouldn't forget to fix this.

Comment 9

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1200228 - Fix content DisplayPort calculation. r=kats

Bug 1200228 - Fix content DisplayPort calculation. r=kats

Comment 10

[Benoit Girard (:BenWa)]

I tested this on the test page and on planet.mozilla.org and it fixes it.

I don't think we need to account for scrolling here in the same way we had to on the compositor.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8655550 [details]
MozReview Request: Bug 1200228 - Fix content DisplayPort calculation. r=kats

https://reviewboard.mozilla.org/r/17927/#review16055

Comment 12

[Benoit Girard (:BenWa)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fccee02c4465

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Can we back out bug 1191539 until you can figure out what's going on with the B2G test failure? The regression is quite user-visible and makes it harder to work on Fennec-APZ because it's not always obvious if a painting error is because of this bug or something else I did in my local patch queue.

Comment 14

[Benoit Girard (:BenWa)]

Yes, I'll have a quick look and if it's not ready I'll back it out early today so that it's in tomorrow' nightly.

I don't know why the failures would be b2g emulator only.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Benoit landed the backout for bug 1191539 on inbound yesterday:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f25ab0817bab

Comment 16

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/f25ab0817bab

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a regression - in case it reopens.