1200363 - [eng polish] Rejigger suggestion_item.xml to use compound drawables

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Allison Naaktgeboren :ally]

We think we can optimize the code, though Fancy Suggestions may make that nearly impossible (Bug 1189725). So this is a follow up to Bug 1189719 while we sort out whether or not this optimization is worth doing.

Comment 1

[Allison Naaktgeboren :ally]

mcomella, since I ended up re-using suggestion_item.xml and getting rid of the magnifying glass in 1189725, is there any thing left to do in SearchEngineRow.java with respect to reuse TextViews, ImageViews, or Views ? I don't think there is?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The view can be switched to use a compound drawable but I don't think that's something you *need* to do – [good next bug] mentored bug?

Comment 3

[Allison Naaktgeboren :ally]

sgtm.

Comment 4

[Varun Joshi (:vjoshi)]

I've tried using a compound drawable instead of the LinearLayout, but the history icon appears very large compared to the text (since it hasn't been scaled). Is there a cleaner way of matching the size of the icon to the text apart from setting the history icon drawable's bounds programatically?

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.