Clone from CloudFront from outside EC2

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: gps, Assigned: coop)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
In bug 1185261 we added support for hosting Mercurial bundles on CloudFront. For machines outside of EC2, downloading from CloudFront is preferred because, well, it's a CDN.

I'm pretty sure that somewhere in bug 1144872 and automation land there are hgrc configs that set the "bundleclone.prefers" Mercurial option to prefer an "ec2region" attribute. I'm also pretty sure that the value for machines in SCL3 and other non-EC2 data centers is to prefer a specific EC2 region.

This bug is about changing the preferences for non-EC2 regions to prefer CloudFront. This is as simple as adding "cdn=true" before any "ec2region" preference. e.g.

   [bundleclone]
   prefers = stream=revlogv1, cdn=true, ec2region=us-west-2

When deployed, this may actually have no effect since Python 2.7.9 is required to download from CloudFront. But we might as well make the change live so it starts working some day.
(Assignee)

Updated

3 years ago
Assignee: nobody → coop
(Assignee)

Comment 1

3 years ago
Created attachment 8714829 [details] [diff] [review]
[puppet] Set cdn=true for bundleclone in hgrc
Attachment #8714829 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 2

3 years ago
Created attachment 8714832 [details] [diff] [review]
[puppet] Set cdn=true for bundleclone in hgrc, v2

Missed the mercurial.ini change on the first pass.
Attachment #8714829 - Attachment is obsolete: true
Attachment #8714829 - Flags: review?(bugspam.Callek)
Attachment #8714832 - Flags: review?(bugspam.Callek)
Comment on attachment 8714832 [details] [diff] [review]
[puppet] Set cdn=true for bundleclone in hgrc, v2

Review of attachment 8714832 [details] [diff] [review]:
-----------------------------------------------------------------

I'm cautious of this change because of greg's comment:

"When deployed, this may actually have no effect since Python 2.7.9 is required to download from CloudFront. But we might as well make the change live so it starts working some day."

But I'm totally trusting greg's c#0 for the whole "is this right". The patch does what greg asks for in c#0 at least, so \o/
Attachment #8714832 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Justin Wood (:Callek) from comment #3)
> I'm cautious of this change because of greg's comment:

Yeah, so this isn't really going to do much for us yet, but will once things like bug 1193461 are addressed.
(Assignee)

Comment 5

3 years ago
Comment on attachment 8714832 [details] [diff] [review]
[puppet] Set cdn=true for bundleclone in hgrc, v2

Review of attachment 8714832 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/puppet/rev/54058e8c2d92
Attachment #8714832 - Flags: checked-in+
(Assignee)

Comment 6

3 years ago
This is in production now.

I'll likely tackle bug 1193461 soon to make this useful.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.