Closed Bug 1202366 Opened 4 years ago Closed 4 years ago

Implement the encoder error mode "HTML" for nsFormSubmission without nsISaveAsCharset

Categories

(Core :: Internationalization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file, 5 obsolete files)

nsISaveAsCharset is needlessly complicated and the functionality needed by nsFormSubmission (a wrapper around nsIUncodeEncoder for implementing https://encoding.spec.whatwg.org/#error-mode ) should be implemented as cleaner code without all the unneeded features.

(nsStandardURL should then be changed to call this new code, too.)
Attached patch Avoid using nsISaveAsCharset (obsolete) — Splinter Review
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attached patch Avoid using nsISaveAsCharset, v3 (obsolete) — Splinter Review
Attachment #8673009 - Attachment is obsolete: true
Attached patch Avoid using nsISaveAsCharset, v4 (obsolete) — Splinter Review
Attachment #8673633 - Attachment is obsolete: true
Blocks: 1214619
The upside is visible in the patch for bug 1214619. It's in a different patch to allow c-c to adjust between this patch and that patch landing.
Attachment #8673655 - Attachment is obsolete: true
Attachment #8678056 - Flags: review?(VYV03354)
Attachment #8678056 - Flags: review?(VYV03354) → review+
Oops. r=NOT_emk in the commit message means r=emk with a failure to edit r=NOT_REVIEWED out completely.
https://hg.mozilla.org/mozilla-central/rev/bc791a37462f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.