Implement the encoder error mode "HTML" for nsFormSubmission without nsISaveAsCharset

RESOLVED FIXED in Firefox 44

Status

()

Core
Internationalization
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment, 5 obsolete attachments)

nsISaveAsCharset is needlessly complicated and the functionality needed by nsFormSubmission (a wrapper around nsIUncodeEncoder for implementing https://encoding.spec.whatwg.org/#error-mode ) should be implemented as cleaner code without all the unneeded features.

(nsStandardURL should then be changed to call this new code, too.)
Created attachment 8672975 [details] [diff] [review]
Avoid using nsISaveAsCharset
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Created attachment 8673633 [details] [diff] [review]
Avoid using nsISaveAsCharset, v3
Attachment #8673009 - Attachment is obsolete: true
Created attachment 8673634 [details] [diff] [review]
Avoid using nsISaveAsCharset, v4
Attachment #8673633 - Attachment is obsolete: true
Created attachment 8678056 [details] [diff] [review]
Avoid using nsISaveAsCharset, v6

The upside is visible in the patch for bug 1214619. It's in a different patch to allow c-c to adjust between this patch and that patch landing.
Attachment #8673655 - Attachment is obsolete: true
Attachment #8678056 - Flags: review?(VYV03354)
Attachment #8678056 - Flags: review?(VYV03354) → review+
Oops. r=NOT_emk in the commit message means r=emk with a failure to edit r=NOT_REVIEWED out completely.

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bc791a37462f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1336836
You need to log in before you can comment on or make changes to this bug.