Remove nsISaveAsCharset & nsSaveAsCharset from m-c

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: hsivonen, Assigned: emk)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [qf-])

Attachments

(2 attachments)

Reporter

Description

4 years ago
As seen in https://mxr.mozilla.org/comm-central/search?string=nsISaveAsCharset , m-c has two callers of nsISaveAsCharset and c-c has one.

The nsPrimitiveHelpers caller shouldn't exist anymore. The nsFormSubmission caller needs to exist, but nsISaveAsCharset is needlessly complicated and the needed functionality should be implemented as cleaner code without all the unneeded features. (Additionally, nsStandardURL should call the same code as nsFormSubmission, but currently does not.)
Reporter

Updated

4 years ago
Depends on: 943296
Reporter

Updated

4 years ago
Depends on: 1202366
Reporter

Updated

4 years ago
Depends on: 1202401
Reporter

Comment 1

4 years ago
The most notable user of nsISaveAsCharset is Enigmail for https://www.mozdev.org/bugs/show_bug.cgi?id=14392 . It's unclear if that code is still needed in Enigmail. In any case, Enigmail catches the exception if nsISaveAsCharset instantiation fails, so things might be OK.

The only other addon with a notable userbase seems to be https://addons.mozilla.org/en-US/firefox/addon/custom-buttons/ , which seems to use nsISaveAsCharset for plain conversion to UTF-8...
Reporter

Updated

4 years ago
See Also: → 1214619
Reporter

Updated

2 years ago

Updated

2 years ago
No longer depends on: post-57-api-changes

Comment 2

2 years ago
Things may have changed since and the only reference in c-c seems unused now.
Attachment #8848780 - Flags: review?(jorgk)

Comment 3

2 years ago
Comment on attachment 8848780 [details] [diff] [review]
patch for c-c [landed in comment #4]

They forgot this in bug 1202401.
Attachment #8848780 - Flags: review?(jorgk) → review+

Comment 4

2 years ago
Comment on attachment 8848780 [details] [diff] [review]
patch for c-c [landed in comment #4]

https://hg.mozilla.org/comm-central/rev/3e7abcf349c2bf5498a985c7cdc4905f7c7c129b
Attachment #8848780 - Attachment description: patch for c-c → patch for c-c [landed in comment #4]
Whiteboard: [qf]

Updated

2 years ago
Whiteboard: [qf] → [qf-]
Assignee

Comment 5

2 years ago
Now no one uses nsISaveAsCharset & nsSaveAsCharset. We can just remove them.
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Reporter

Comment 7

2 years ago
mozreview-review
Comment on attachment 8893674 [details]
Bug 1202362 - Remove nsISaveAsCharset & nsSaveAsCharset.

https://reviewboard.mozilla.org/r/164772/#review170168

Thank you!
Attachment #8893674 - Flags: review?(hsivonen) → review+

Comment 8

2 years ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/4b913ce6d827
Remove nsISaveAsCharset & nsSaveAsCharset. r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/4b913ce6d827
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.