Closed Bug 1202362 Opened 9 years ago Closed 8 years ago

Remove nsISaveAsCharset & nsSaveAsCharset from m-c

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Project Flags:
Performance Impact none
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: hsivonen, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

patch for c-c [landed in comment #4]
806 bytes, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
Bug 1202362 - Remove nsISaveAsCharset & nsSaveAsCharset.
59 bytes, text/x-review-board-request
hsivonen
: review+
Details
As seen in https://mxr.mozilla.org/comm-central/search?string=nsISaveAsCharset , m-c has two callers of nsISaveAsCharset and c-c has one. The nsPrimitiveHelpers caller shouldn't exist anymore. The nsFormSubmission caller needs to exist, but nsISaveAsCharset is needlessly complicated and the needed functionality should be implemented as cleaner code without all the unneeded features. (Additionally, nsStandardURL should call the same code as nsFormSubmission, but currently does not.)
Depends on: 943296
Depends on: 1202366
Depends on: 1202401
The most notable user of nsISaveAsCharset is Enigmail for https://www.mozdev.org/bugs/show_bug.cgi?id=14392 . It's unclear if that code is still needed in Enigmail. In any case, Enigmail catches the exception if nsISaveAsCharset instantiation fails, so things might be OK. The only other addon with a notable userbase seems to be https://addons.mozilla.org/en-US/firefox/addon/custom-buttons/ , which seems to use nsISaveAsCharset for plain conversion to UTF-8...
See Also: → 1214619
Depends on: post-57-api-changes
Blocks: post-57-api-changes
No longer depends on: post-57-api-changes
Things may have changed since and the only reference in c-c seems unused now.
Attachment #8848780 - Flags: review?(jorgk)
Comment on attachment 8848780 [details] [diff] [review] patch for c-c [landed in comment #4] They forgot this in bug 1202401.
Attachment #8848780 - Flags: review?(jorgk) → review+
Comment on attachment 8848780 [details] [diff] [review] patch for c-c [landed in comment #4] https://hg.mozilla.org/comm-central/rev/3e7abcf349c2bf5498a985c7cdc4905f7c7c129b
Attachment #8848780 - Attachment description: patch for c-c → patch for c-c [landed in comment #4]
Whiteboard: [qf]
Whiteboard: [qf] → [qf-]
Now no one uses nsISaveAsCharset & nsSaveAsCharset. We can just remove them.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 8893674 [details] Bug 1202362 - Remove nsISaveAsCharset & nsSaveAsCharset. https://reviewboard.mozilla.org/r/164772/#review170168 Thank you!
Attachment #8893674 - Flags: review?(hsivonen) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/autoland/rev/4b913ce6d827 Remove nsISaveAsCharset & nsSaveAsCharset. r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/4b913ce6d827
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Performance Impact: --- → -
Whiteboard: [qf-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: