Closed Bug 1202383 Opened 8 years ago Closed 8 years ago

Use build time preprocessor to enable/disable Sync on System

Categories

(Firefox OS Graveyard :: Sync, defect)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S7 (18Sep)

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review 
Bug 1191770 added a mechanism for enabling/disabling features on apps. We can now use that to enable/disable Firefox Sync on the System app.
Assignee: nobody → ferjmoreno
Target Milestone: --- → FxOS-S7 (18Sep)
Summary: Use built time preprocessor to enable/disable Sync on System → Use build time preprocessor to enable/disable Sync on System
Blocks: fxos-sync
Depends on: 1191770
Attachment #8661780 - Flags: review?(etienne)
Comment on attachment 8661780 [details] [review]
[gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master

Wow I know nothing about the build system! :)

So r=me for the comments in core.js I guess, but I'm not sure who should do the real review.
Attachment #8661780 - Flags: review?(etienne)
(In reply to Etienne Segonzac (:etienne) from comment #2)
> Comment on attachment 8661780 [details] [review]
> [gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master
> 
> Wow I know nothing about the build system! :)

Come on, don't be that modest :P
Comment on attachment 8661780 [details] [review]
[gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master

Ricky, could you take a look at this patch, please? Thanks!
Attachment #8661780 - Flags: review?(rchien)
Comment on attachment 8661780 [details] [review]
[gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master

LGTM
Attachment #8661780 - Flags: review?(rchien) → review+
https://github.com/mozilla-b2g/gaia/commit/32c86b3d6c14a1bd27d45fda5b2d6d48991345ff
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 1211833
See Also: → 1211833
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.