Closed
Bug 1202383
Opened 9 years ago
Closed 9 years ago
Use build time preprocessor to enable/disable Sync on System
Categories
(Firefox OS Graveyard :: Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S7 (18Sep)
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Whiteboard: [partner-cherry-pick])
Attachments
(1 file)
Bug 1191770 added a mechanism for enabling/disabling features on apps. We can now use that to enable/disable Firefox Sync on the System app.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ferjmoreno
Target Milestone: --- → FxOS-S7 (18Sep)
|
|
Assignee | |
Updated•9 years ago
|
Summary: Use built time preprocessor to enable/disable Sync on System → Use build time preprocessor to enable/disable Sync on System
|
|
Assignee | |
Updated•9 years ago
|
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8661780 -
Flags: review?(etienne)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8661780 [details] [review] [gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master Wow I know nothing about the build system! :) So r=me for the comments in core.js I guess, but I'm not sure who should do the real review.
Attachment #8661780 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Etienne Segonzac (:etienne) from comment #2) > Comment on attachment 8661780 [details] [review] > [gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master > > Wow I know nothing about the build system! :) Come on, don't be that modest :P
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8661780 [details] [review] [gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master Ricky, could you take a look at this patch, please? Thanks!
Attachment #8661780 -
Flags: review?(rchien)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8661780 [details] [review] [gaia] ferjm:bug1202383.disablesync > mozilla-b2g:master LGTM
Attachment #8661780 -
Flags: review?(rchien) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/32c86b3d6c14a1bd27d45fda5b2d6d48991345ff
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•