Closed Bug 1211833 Opened 4 years ago Closed 4 years ago
Merge preprocessing functionality to TV to enable/disable sync
As Mozilla, I want to back port Data sync mechanism from smart phone to TV
46 bytes, text/x-github-pull-request
|Details | Review|
Should be able to enable/disable Sync feature on TV with preprocessor functionality merged.
See Also: → 1210697
Target Milestone: --- → FxOS-S10 (30Oct)
Attachment #8675717 - Flags: review?(yliao)
Comment on attachment 8675717 [details] [review] [gaia] ferjm:bug1211833.preprocessing.tv > mozilla-b2g:master LGTM! Thank you for the help! Works as it should, I'm curious that do we also need to remove the sync permission and IAC connection in the manifest?
Attachment #8675717 - Flags: review?(yliao) → review+
Thank you YiFan! Unfortunately the preprocessor does not support manifests yet. And it is harmless to leave the permissions and IAC connection configuration in the manifest. But I agree it'd be nice to have. I'll file a bug for it. https://github.com/mozilla-b2g/gaia/commit/908054053843b5adb2f433233cb2887b5dbd4d6c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I filed bug 1216410 for the manifest thing.
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in before you can comment on or make changes to this bug.