1202735 - Startup warning: While creating services from category 'profile-after-change', service for entry 'Sapi Speech Synth', contract ID '@mozilla.org/synthsapi;1' does not implement nsIObserver

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[:Gijs (back August 25; he/him)]

I see this on my Windows 8.1 machine every day, and I'm wondering what's breaking. Maybe related to / dupe of bug 1080863 ?

Comment 1

[:Gijs (back August 25; he/him)]

Err, meant bug 922841.

Comment 2

[Makoto Kato [:m_kato]]

take this.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Add nsIObserver

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Add nsIObserver

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8683064 [details] [diff] [review]
Add nsIObserver

add nsIObserver and initalize by profile-after-change

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8683064 [details] [diff] [review]
Add nsIObserver

Review of attachment 8683064 [details] [diff] [review]:
-----------------------------------------------------------------

One question below.

::: dom/media/webspeech/synth/windows/SapiService.cpp
@@ +369,5 @@
> +SapiService::Observe(nsISupports* aObject, const char* aTopic,
> +                     const char16_t* aMessage)
> +{
> +  if (!strcmp(aTopic, "profile-after-change")) {
> +    Init();

Is it necessary to call init here? Isn't that the job of SapiModule?

Comment 8

[Makoto Kato [:m_kato]]

(In reply to Eitan Isaacson [:eeejay] from comment #7)
> Comment on attachment 8683064 [details] [diff] [review]
> Add nsIObserver
> 
> Review of attachment 8683064 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> One question below.
> 
> ::: dom/media/webspeech/synth/windows/SapiService.cpp
> @@ +369,5 @@
> > +SapiService::Observe(nsISupports* aObject, const char* aTopic,
> > +                     const char16_t* aMessage)
> > +{
> > +  if (!strcmp(aTopic, "profile-after-change")) {
> > +    Init();
> 
> Is it necessary to call init here? Isn't that the job of SapiModule?

I change init to profile-after-change.  But I think that this fix cannot check Init is failed.  So I will update this.

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Add nsIObserver v2

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8687816 [details] [diff] [review]
Add nsIObserver v2

Add nsIObserver simply.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6cd7a6e5e09

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6cd7a6e5e09