1202943 - Clean up SeaMonkey's buildbotcustom/buildbot-config code

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

SeaMonkey's buildbotcustom code require some attention in both coverage and, for lack of a better phrase, code utility.  There's a lot of stuff in buildbotcustom that the SeaMonkey infra doesn't use (i.e. generateBranchObjects in process/factory.py).

The rationale:
1) Code clarity. - It lessens the burden of maintaining code which we don't use and decreases code bloat. (Do we or have we ever used the sharkFactory?)
2) Reformat code to fit Pep8. (Cleaner code is easier to maintain :) )

This bug depends on the completion of other bugs, since it is unwise to work on this while other bugs (i.e. bug 1072713) is still open (read:. don't want to bitrot those bugs) as this is a lower priority bug.

Comment 1

[Edmund Wong (:ewong)]

Attachment: [custom] misc.py changes

Comment 2

[Edmund Wong (:ewong)]

note: all these changes will be pushed to the new_infra_clean branch.

Comment 3

[Edmund Wong (:ewong)]

Attachment: [custom] common.py

Comment 4

[Edmund Wong (:ewong)]

Attachment: [custom] factory.py

Comment 5

[Edmund Wong (:ewong)]

Attachment: [custom] changes/hgpoller.diff

Comment 6

[Edmund Wong (:ewong)]

Attachment: [custom] removed a bunch of unused files.

Comment 7

[Edmund Wong (:ewong)]

Attachment: [custom] mock.py

Comment 8

[Edmund Wong (:ewong)]

Attachment: ftppoller.diff

Comment 9

[Edmund Wong (:ewong)]

Attachment: [custom] cleaned up status/*.py

Comment 10

[Edmund Wong (:ewong)]

Attachment: [custom] cleaned up status/ status/db *.py

Comment 11

[Edmund Wong (:ewong)]

Attachment: [custom] steps/*.py changes

Comment 12

[Edmund Wong (:ewong)]

Attachment: [custom] buildbotcustom root dir changes

Comment 13

[Edmund Wong (:ewong)]

Attachment: [custom] test/*.py changes

Comment 14

[Edmund Wong (:ewong)]

Attachment: [configs] remove unused code.

Comment 15

[Edmund Wong (:ewong)]

Attachment: [configs] cleaned up the code.

Comment 16

[Edmund Wong (:ewong)]

Attachment: [configs] followup patch

Comment 17

[Edmund Wong (:ewong)]

Attachment: [configs] followup nit fix.

Comment 18

[Edmund Wong (:ewong)]

Attachment: [custom] followup fix when combined with config changes.

Comment 19

[Edmund Wong (:ewong)]

Attachment: [custom] s/buildbot/buildbotcustom/

Comment 20

[Edmund Wong (:ewong)]

Attachment: [custom] s/buildbot/buildbotcustom/

forgot to qrefresh.

Comment 21

[Edmund Wong (:ewong)]

Attachment: [custom] s/buildbot/buildbotcustom/ and other fixes.

Comment 22

[Edmund Wong (:ewong)]

Attachment: [configs] config changes to go with custom changes in new_infra_clean

Comment 23

[Edmund Wong (:ewong)]

Closing as we no longer use buildbot.