1203052 - Loop's contact search no longer shows the "no matching results" view

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Regression from bug 1192372:

Contact search (if more than 7 contacts, search bar will appear), when typing the keyword will never show the no search results view as it removes the keyword or letter from the input(empties input) if the letter or word is not present in the contacts.

Comment 1

[Mark Banner (:standard8)]

Attachment: Loop's contact search no longer shows the "no matching results" view.

I took a quick look at this, and noticed the terminal console was complaining about the lack of a missing string. I took a look back at bug 1196499 (specifically https://hg.mozilla.org/integration/fx-team/rev/726807b7361a#l3.11) and came to the conclusion that we'd hit a bad merge when doing bug 1192372.

Removing the old string, and hence matching the structure back to post bug 1196499, fixes the search again.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8658597 [details] [diff] [review]
Loop's contact search no longer shows the "no matching results" view.

Review of attachment 8658597 [details] [diff] [review]:
-----------------------------------------------------------------

The code fix is fine, but it'd be awfully nice to be able to catch regressions like this automatically.  Would you be willing to file a spin-off bug for the impl of an "l10n string coverage" tool?  I think this would just check all the strings that got used from the unit tests, and then make sure that they were in the appropriate file...

Comment 3

[Mark Banner (:standard8)]

Filed bug 1203258.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/275ecc1d1a39

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/275ecc1d1a39

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Based on bug 1212083, contacts were removed from Hello so there is no point verifying this thus removing qe-verify+.