120332 - Items in left pane misaligned

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Ben Bucksch (:BenB)]

All text in the left pane (the "contents" pane with the accounts etc.) of the
Account Manager is horizontally aligned identically. So, it looks like:
> My Account
  Server Settings
  Copies and Folders
  Addressing
  Security
  Local folders
  Outgoing server (SMTP)

Since neither Local folders not Outgoing Server has a twisty (arrow) (probably
because neither have children), this looks as if they were on the same
hierarchical level as Security, i.e. part of My Account, while they are not -
they are hierarchically at the top level, that of accounts. This is confusing.

Expected result:
Make in some way the hierarchy visually obivous. Use twisties, idention, lines
or whatever.

Comment 1

[Ben Bucksch (:BenB)]

> Since neither Local folders not Outgoing Server has a twisty (arrow) (probably
> because neither have children)

No, this is irrelevant. Securtiy has no children either, is on a different level
as Local Folders, yet has the same indention. Must be a bug in the tree drawing
code.

Comment 2

[djk]

Have seen this on w98 for a while now also.

Comment 3

[Ninoschka Baca]

I agree that it is confusing. The Account Setup spec has subitems indented more
than what exists today:

>My Account
    Server Settings
    Copies and Folders
    Addressing
    Security
 Local Folders 
 Outgoing server (SMTP)

Marking nsbeta1 so that it's clear the Local Folders and Outgoing SMTP Server
panels are top level items, not subitems of an account.

Comment 4

[jglick]

This is a regression then. Acct levels used to have twisties.

Comment 5

[racham]

They still have twisties. Items are misaligned as tree children need to be
properly  by default as opposed to doing the right thing when twisty is closed
and opened.

Comment 6

[racham]

Attachment: snapshot of the problem

If there are more number of accounts OR if you reduce the AccountManager window
size and use the scrollbar to move up & down in the tree, you will see all
redrawn items are properly indented. We need to fix the issue (could be a paint
issue) with the initial launch.

Comment 7

[Ninoschka Baca]

*** Bug 122774 has been marked as a duplicate of this bug. ***

Comment 8

[scottputterman]

reassigning to shliang.

Comment 9

[shliang]

this is a problem in trees in general, not just account manager

Comment 10

[John Morrison]

First, we kill all the trees...

Comment 11

[Ben Bucksch (:BenB)]

What's the ETA on that? This instance is quote confusing...

Comment 12

[John Morrison]

The bug this depends upon (bug 110156) is scheduled in the next milestone,
is nsbeta1+, and is not something that will not get done.

Comment 13

[John Morrison]

*** Bug 128279 has been marked as a duplicate of this bug. ***

Comment 14

[Peter Trudelle]

nsbeta1- per ADT triage team

Comment 15

[Ben Bucksch (:BenB)]

I think the Mailnews Accounts instance should be fixed for 1.0.

Comment 16

[scottputterman]

From what I've been told, 110156 (which got +'d) should fix the account manager
bug.  I hope it does at least.

Comment 17

[Joe Hewitt (gone)]

fixed by 110156 tree conversion work