Closed Bug 1203348 Opened 9 years ago Closed 9 years ago

Move remaining DateTimeFormat uses to Intl/async

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S7 (18Sep)

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] zbraniecki:1203348-system-intl > mozilla-b2g:master
46 bytes, text/x-github-pull-request
apastor
: review+
Details | Review 
There's still a bunch of date time formatting placed where System uses l10n_date's functions.

For all formattings we should use Intl, and for prettyDate we should use an async version.
Assignee: nobody → gandalf
Blocks: 1170963
Whiteboard: [systemsfe]
Comment on attachment 8659017 [details] [review]
[gaia] zbraniecki:1203348-system-intl > mozilla-b2g:master

Alberto, can you review this or redirect to someone who can?
Attachment #8659017 - Flags: review?(apastor)
Comment on attachment 8659017 [details] [review]
[gaia] zbraniecki:1203348-system-intl > mozilla-b2g:master

Just a quick comment in GH about a possible remaining file, but the code looks good to me. Thanks for fixing this!
Attachment #8659017 - Flags: review?(apastor) → review+
https://github.com/mozilla-b2g/gaia/commit/77b86130954fb5769c9b49f3184b37d1d9148225
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
Depends on: 1208478
Depends on: 1213083
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: