1203885 - [Contacts]It always prompts "Imported X contacts. contactsMerged" from a vcard so user don't know how many contacts are merged after importing.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
[Aries KK v2.5][Flame KK v2.5][Email] When importing contacts from email or importing them again, it always prompts "Imported 12 contacts. contactsMerged". From the prompt words "contactsMerged", so user doesn't know how many contacts were merged.

Found time: 01:45
Attachments: logcat_0145.txt and Aries_v2.5.3gp.
Test file: 2015_9_9_12.vcf or 2015_9_9_10.vcf

[2.Testing Steps]: 
1. Receive a email with a vcard with 12 contacts.
2. Download and open the vcard file.
3. Tap "Import all" icon.
4. Open the .vcf file and tap "Import all" again.

[3.Expected Result]: 
Step 3. It should prompt "Imported 12 contacts." or "Imported 12 contacts. No duplicated contacts merged".
Step 4. It should prompt "Imported 12 contacts. 12 contacts merged".

[4.Actual Result]: 
Step 3 & step 4. Contacts are imported successfully, but it always prompts "Imported 12 contacts. contactsMerged". From the prompt message "contactsMerged", user don't know how many contacts are merged while importing.  And there is no space between the prompt words "contactsMerged".

[5.Reproduction build]: 
Device: Flame KK 2.2 (Disabled) 
Build ID               20150910032509
Gaia Revision          7a427e0f8aa6c185a9e22358006b97c19435ca4a
Gaia Date              2015-09-09 13:06:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0d9c46d01861
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150910.070213
Firmware Date          Thu Sep 10 07:02:24 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5 (Affected)
Build ID               20150910150202
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/mozilla-

central/rev/7671701d15cadd2b343fc27685231e0689bb71df
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150910.182915
Firmware Date          Thu Sep 10 18:29:25 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Affected)
Build ID               20150911000328
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/integration/mozilla-

inbound/rev/c0abc2a6e11f52761366e029eb1bae4c9864a8a3
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150910.232411
Firmware Date          Thu Sep 10 23:24:19 UTC 2015
Bootloader             s1


[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

[8.Note]:
It prompts "Not enabled yet" on Flame KK v2.2.

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: Aries_v2.5.3gp

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: logcat_0145.txt

Comment 3

[James Burke [:jrburke]]

Looking at the video, and searching for contactsMerged in the code, this seems to be controlled by the Contacts app so switching the component to that.

Comment 4

[Maria Angeles Oteo (:oteo)]

[Blocking Requested - why for this release]:

I think this is a regression introduced when landing the merging of #open and #import activities (bug 1184075 and bug 1184077) as part of the NGA work, as I remember seeing it working fine in master before this work.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Regression from 2.2, blocking.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] fcampo:vcard-import-merged-error-1203885 > mozilla-b2g:master

Comment 7

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/31868

property name change

Comment 8

[Maria Angeles Oteo (:oteo)]

This issue happens in both branches, master and NGA, so leaving 2.5+ blocking flag.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8661821 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/31868

>https://github.com/mozilla-b2g/gaia/pull/31868

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/4277332d13580d2f7adc06749aaed381095814b4

Nga branch:

https://github.com/mozilla-b2g/gaia/commit/5aa2f431f7fe9cd175abac59e5e5f21df1671127

Comment 11

[Maria Angeles Oteo (:oteo)]

Tested in latest master build (9/24) and working fine. Thanks Fernando!

Environmental Variables (9/24):
flame master (2.5 version)
Build ID: 20150924072151
Gecko: 65a0dd9
Gaia: 7e72976
Platform version: 44.0a1

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: 
Step 3. It prompts correct message "Imported 12 contacts. No duplicated contacts merged".
Step 4. It prompts correct message "Imported 12 contacts. 12 contacts merged" and the contacts are merged normally.

See attachment: verified_Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150923150203
Gaia Revision          8472f0c736660072799aaae60e4b6001a6aaceb4
Gaia Date              2015-09-23 10:29:02
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4a46de29431baa621d98d8f1168e43297ce1a916
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150923.184655
Firmware Date          Wed Sep 23 18:47:17 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150923233246
Gaia Revision          8472f0c736660072799aaae60e4b6001a6aaceb4
Gaia Date              2015-09-23 10:29:02
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f1dffc8682fbba463cb4bb305f293ddcccbc20b4
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150923.225204
Firmware Date          Wed Sep 23 22:52:12 UTC 2015
Bootloader             s1

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp