1204664 - [Music][NGA] UI issues with playlist-detail view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Justin D'Arcangelo [:justindarc]]

The playlist-detail views are currently utilizing list "groups" when they should not be. Additionally, these views are missing a "Shuffle" option that is present in the OGA Music app.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1204664 > mozilla-b2g:master

Comment 3

[Justin D'Arcangelo [:justindarc]]

jsavory: Can you confirm what we discussed on IRC about removing the "Shuffle" button for the built-in playlist detail view? We will have "Shuffle playlist" buttons for user-defined playlists (once we have them), but in the meantime, it doesn't make sense to shuffle these built-in lists since the whole idea of them is to preserve a pre-sorted order. Thanks!

Comment 4

[Jacqueline Savory [:jsavory] UX]

Hi Justin, yes I agree that we should remove the 'shuffle' button from the preset playlists. It does seem a little confusing in this location and removing it helps to clean up the UI. Also, the user still has the ability to put the playlist on shuffle if they choose to do so from the song details view, I just don't think it needs to be showcased on the higher level.

Comment 5

[Jim Porter (:squib)]

Comment on attachment 8663203 [details] [review]
[gaia] justindarc:bug1204664 > mozilla-b2g:master

rs=me

Comment 6

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/5889578486745bd88b3d5066796ece0f4438d7ac

Comment 7

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest Flame KK 2.5 by the STR in comment 0.

Actual results: It doesn't show the 'shuffle' button/icon and shows as list without 'Group' in playlists detail view in NGA music app. 

See attachment: verify_Aries_v2.5(NGA&OGA music).png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150928150204
Gaia Revision          01ffe82cf088ca8fda9fe6783dc5cad2c3dde01c
Gaia Date              2015-09-28 08:49:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/031db40e2b558c7e4dd0b4c565db4a992c1627c8
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150928.182514
Firmware Date          Mon Sep 28 18:25:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 8

[Shally Li（leave from Mozilla）]

Attachment: verify_Aries_v2.5(NGA&OGA music).png

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verify_Flame_v2.5(NGA&OGA music).png

Comment 10

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest Flame KK 2.5 by the STR in comment 0.

Actual results: It doesn't show the 'shuffle' button/icon and shows as list without 'Group' in playlists detail view in NGA music app. 

See attachment: verify_Flame_v2.5(NGA&OGA music).png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150928150204
Gaia Revision          01ffe82cf088ca8fda9fe6783dc5cad2c3dde01c
Gaia Date              2015-09-28 08:49:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/031db40e2b558c7e4dd0b4c565db4a992c1627c8
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150928.182514
Firmware Date          Mon Sep 28 18:25:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0