Closed Bug 1204917 Opened 4 years ago Closed 4 years ago

Remove nightly flag from Mobile Grid Tabs Tray work

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: mhaigh, Assigned: sebastian)

References

Details

Attachments

(5 files)

In meta bug 1158277 we tracked some changes to put nightly flags around some work done for the mobile tabs tray.  This bug is tracking the work needed to do to remove those nightly flags and let it ride the trains
Assignee: mhaigh → s.kaspari
Once we fix bug 1214602, let's get rid of this Nightly flag. Then we can create a separate feature-based flag for the "compact tabs" work, which is tracked in bug 1202861.
Bug 1204917 - Remove Nightly flag for back button in tabs tray. r?margaret
Attachment #8676189 - Flags: review?(margaret.leibovic)
Bug 1204851 - Inline back button in tabs panel layout. r?margaret

Previously we used a ViewStub to only show the back button for some configurations. Now we
show the button always, so we can get rid of the ViewStub.
Attachment #8676190 - Flags: review?(margaret.leibovic)
Bug 1204917 - Remove Nightly flag from full screen tabs tray. r?margaret
Attachment #8676191 - Flags: review?(margaret.leibovic)
Bug 1204917 - Remove Nightly flag from tab thumbnail aspect ratio. r?margaret
Attachment #8676192 - Flags: review?(margaret.leibovic)
Bug 1204917 - Remove Nightly flag: Always grow close button hit area. r?margaret
Attachment #8676193 - Flags: review?(margaret.leibovic)
(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> Created attachment 8676191 [details]
> MozReview Request: Bug 1204917 - Remove Nightly flag from full screen tabs
> tray. r?margaret
> 
> Bug 1204917 - Remove Nightly flag from full screen tabs tray. r?margaret

This patch removes the Nightly flag and effectively short-circuits the height calculations by always returning the same size; hence we can remove even more code/logic. I filed bug 1216489 for that.
Comment on attachment 8676189 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag for back button in tabs tray. r?margaret

https://reviewboard.mozilla.org/r/22615/#review20117
Attachment #8676189 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8676190 [details]
MozReview Request: Bug 1204851 - Inline back button in tabs panel layout. r?margaret

https://reviewboard.mozilla.org/r/22617/#review20119
Attachment #8676190 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8676191 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag from full screen tabs tray. r?margaret

https://reviewboard.mozilla.org/r/22619/#review20121

Nice to see us remove all this logic :)
Attachment #8676191 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8676192 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag from tab thumbnail aspect ratio. r?margaret

https://reviewboard.mozilla.org/r/22621/#review20125

::: mobile/android/base/tabs/TabsPanelThumbnailView.java
(Diff revision 1)
> -            return ThumbnailHelper.TOP_SITES_THUMBNAIL_ASPECT_RATIO;

Is there a bug on file to update our top sites to use this same aspect ratio as well?
Attachment #8676192 - Flags: review?(margaret.leibovic) → review+
Attachment #8676193 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8676193 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag: Always grow close button hit area. r?margaret

https://reviewboard.mozilla.org/r/22623/#review20127
(In reply to :Margaret Leibovic from comment #12)
> Is there a bug on file to update our top sites to use this same aspect ratio
> as well?

I think I saw some mockups about that? But I don't know about a bug. Anthony?
Flags: needinfo?(alam)
Nope not yet. We intentionally decoupled it because the use-cases and problems of Top Sites and tabs tray are quite different. 

I think we should look at Top sites separately and I've filed bug 1213140 for that.
Flags: needinfo?(alam)
You need to log in before you can comment on or make changes to this bug.