Move the ToS links on the standalone UI to be shown below the Join button

RESOLVED FIXED in Firefox 44

Status

P2
normal
Rank:
21
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: dcritchley)

Tracking

unspecified
mozilla44
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox44 fixed)

Details

User Story

Acceptance:

- ToS link is shown below the join conversation button.
- Clicking the ToS links continue to dispatch the existing RecordClick action.
- Join button continues to work as expected.

Dev plan:

- Split out the existing Join room button from StandaloneRoomInfoArea to a new view.
- Change the joinRoom prop to a function in the new view that dispatches the JoinRoom action directly.
- Move the existing ToS link handling from the StandaloneRoomFooter to the new view.
- Update tests appropriately.

Attachments

(2 attachments, 1 obsolete attachment)

As part of the UX refresh, we should move the ToS link from the footer to below the join button.
Flags: firefox-backlog+
Rank: 20
Rank: 20 → 21
(Assignee)

Updated

3 years ago
Assignee: nobody → david.critchley
(Assignee)

Comment 1

3 years ago
Should look like this:
http://i.sevaan.com/image/031q2Z3M1N0R
Yes, but don't worry about the look of the join button.

It might be simpler with the dev plan to move the ToS into a new view - I'll need a separate view for bug 1208466. So e.g. the new ToSView would render just the <p> element with the text content, and contain the existing _getContent & recordClick.

We might still want a separate view for the button + tos, but I think that could come later with a rework of the "InfoArea" elements.
(Assignee)

Comment 3

3 years ago
UX/UI image for ToS change from Sevaan:
http://i.sevaan.com/image/031q2Z3M1N0R

Sevaan requested text color to be #999999 due to current dark background. Also, requested period to be added to end of sentence, will change that as part of this bug fix.
(Assignee)

Comment 4

3 years ago
Created attachment 8667000 [details] [diff] [review]
Attachment to Bug 1205206 - Move the ToS links on the standalone UI to be shown below the Join button

Moving Loop Standalone Terms of Service text from footer to under Join button
Attachment #8667000 - Flags: ui-review?(sfranks)
Attachment #8667000 - Flags: review?(standard8)
(Assignee)

Comment 5

3 years ago
Created attachment 8667001 [details]
Screenshot showing changes to string, color and position
Comment on attachment 8667000 [details] [diff] [review]
Attachment to Bug 1205206 - Move the ToS links on the standalone UI to be shown below the Join button

Review of attachment 8667000 [details] [diff] [review]:
-----------------------------------------------------------------

Almost there, just needs a few tweaks to make the css a bit better.

::: browser/components/loop/standalone/content/css/webapp.css
@@ +59,5 @@
>  
> +/* Terms of Service */
> +
> +.terms-service {
> +  margin-top:20px;

Given this is a location specific setting for the margin, I would prefer for us to use `.room-inner-info-area > .terms-service` as the selector. That way we're keeping the styling of the element to itself, but using the parent elements to manage the layout.

nit: need a space after the colon.

@@ +64,5 @@
> +}
> +
> +.terms-service,
> +.terms-service a {
> +  color:#999;

Please use `.terms-service > a` if its really necessary. A child selector has better performance than a descendent selector.

nit: need a space after the colon.

@@ -246,5 @@
>  .room-inner-info-area {
>    color: #fff;
>    margin: auto;
> -  /* 290px is the width of the widest info child, i.e., a tile */
> -  width: 290px;

If we're removing this, we need a small amount of horizontal padding to avoid the case where strings might touch the sides of the containing box. Probably something like 5px either side.
Attachment #8667000 - Flags: review?(standard8) → review-
Blocks: 1209632
(Assignee)

Comment 7

3 years ago
Created attachment 8667563 [details] [diff] [review]
Attachment to Bug 1205206 - Move the ToS links on the standalone UI to be shown below the Join button

Moving Loop Standalone Terms of Service text from footer to under Join button
Attachment #8667000 - Attachment is obsolete: true
Attachment #8667000 - Flags: ui-review?(sfranks)
Attachment #8667563 - Flags: review?(standard8)
Comment on attachment 8667563 [details] [diff] [review]
Attachment to Bug 1205206 - Move the ToS links on the standalone UI to be shown below the Join button

Review of attachment 8667563 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8.
Attachment #8667563 - Flags: review?(standard8) → review+
https://hg.mozilla.org/mozilla-central/rev/99c2739225b0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1218450

Updated

3 years ago
Iteration: --- → 44.1 - Oct 5
You need to log in before you can comment on or make changes to this bug.