Closed Bug 1209632 Opened 4 years ago Closed 4 years ago

Remove the footer of Loop's standalone page

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
5

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Iteration:
44.2 - Oct 19
Tracking Status
firefox44 --- fixed

People

(Reporter: standard8, Assigned: dcritchley)

References

Details

User Story

Acceptance criteria:

- No footer on the standalone UI
- The Mozilla logo is located in the bottom-right hand corner of the focus stream (normally remote video, but window/tab share video if being shown).
- The Mozilla logo looks fine or disappears(?) at narrow screen widths.

Additional Dev notes:

- Look for the .standalone-room-wrapper > .media-layout classes in conversation.css, remove the height of the footer from the calculations
- Remember to remove all the .rooms-footer classes in webapp.css

Attachments

(3 files, 4 obsolete files)

As part of the ongoing work, we should remove the footer of the standalone. Suggest this work happens after bug 1205206.

See user story for details.
We probably want to do one of:

- create the logo element in MediaLayoutView and have a prop to toggle it on/off
- might be able to do it via passing in a child to MediaLayoutView & positioning.
- Or, just have it created & positioned via StandaloneRoomView.

I don't think I like the last two so much, as it would make it harder to position in the correct place - especially if we change the layout of the media view.

If we use a prop, we could have a generic thing like "enableLogos" or something, that would later apply to the Firefox Logo & maybe the Help icon (that we'll move in a separate bug).
Points: --- → 5
Rank: 21
Blocks: 1209686
Assignee: nobody → david.critchley
Attached image Removed Footer (obsolete) —
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8668580 - Flags: ui-review?(sfranks)
Attachment #8668580 - Flags: review?(standard8)
Attachment #8668570 - Attachment is obsolete: true
Ignore the mockup. Please use the floating footer in Vicky's link clicker mockups, matching it's functionality and styling.
Comment on attachment 8668580 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page

Need a screenshot, thanks!
Attachment #8668580 - Flags: ui-review?(sfranks)
Comment on attachment 8668580 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page

Review of attachment 8668580 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, so per Vicky's mocks, the mozilla logo should be displayed all the time, so I think you can drop that code. Apart from that, its looking good.
Attachment #8668580 - Flags: review?(standard8)
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8668580 - Attachment is obsolete: true
Attachment #8668730 - Flags: review?(standard8)
Comment on attachment 8668730 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page

Review of attachment 8668730 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/standalone/content/js/standaloneRoomViews.jsx
@@ +591,5 @@
> +     * @private
> +     */
> +    _shouldShowLogo: function() {
> +      if(this.props.showLogo) {
> +        return this.props.showLogo;

What's the reason for keeping this optional functionality? I don't think it is worth it if we're not using it.

If there's a really good reason, then we need to add test coverage as well.
Attachment #8668730 - Flags: review?(standard8) → review-
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8668730 - Attachment is obsolete: true
Attachment #8669044 - Flags: review?(standard8)
Comment on attachment 8669044 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page

Review of attachment 8669044 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8. Don't forget Sevaan needs a screenshot for ui-review.
Attachment #8669044 - Flags: review?(standard8) → review+
Attachment #8669149 - Flags: ui-review?(sfranks)
Comment on attachment 8669149 [details]
Screenshot of changes for UI Review

The margins should all be even: http://i.sevaan.com/image/3Z0n1k0J3Y1H

Let's see it at 12px?

Also, could you include a screenshot of what this looks like over connected video?

Thanks!
Attachment #8669149 - Flags: ui-review?(sfranks) → ui-review-
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8669044 - Attachment is obsolete: true
Attachment #8669813 - Flags: ui-review?(sfranks)
Attachment #8669813 - Flags: review?(dmose)
Comment on attachment 8669813 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page

Reviewed with :dcritch over Vidyo
Attachment #8669813 - Flags: ui-review?(sfranks) → ui-review+
Attachment #8669814 - Flags: ui-review?(sfranks) → ui-review+
(In reply to David Critchley (:dcritch) from comment #13)
> Created attachment 8669813 [details] [diff] [review]
> Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
> 
> Removing footer from Loop Standalone, moved Logo to mediaLayoutView

Added some scope to this bug, since I was in the area anyway. Fixing margins and size of Conversation Toolbar as per request from Sevaan, to line up with the Mozilla logo and vicki's mocks:
http://i.sevaan.com/image/2U0U0R0J2j13
Attachment #8669813 - Flags: review?(dmose) → review?(standard8)
Comment on attachment 8669813 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page

Review of attachment 8669813 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8
Attachment #8669813 - Flags: review?(standard8) → review+
Depends on: 1212787
https://hg.mozilla.org/mozilla-central/rev/ee116a783005
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Iteration: --- → 44.2 - Oct 19
You need to log in before you can comment on or make changes to this bug.