Closed
Bug 1209632
Opened 9 years ago
Closed 9 years ago
Remove the footer of Loop's standalone page
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox44 fixed)
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: standard8, Assigned: dcritchley)
References
Details
User Story
Acceptance criteria: - No footer on the standalone UI - The Mozilla logo is located in the bottom-right hand corner of the focus stream (normally remote video, but window/tab share video if being shown). - The Mozilla logo looks fine or disappears(?) at narrow screen widths. Additional Dev notes: - Look for the .standalone-room-wrapper > .media-layout classes in conversation.css, remove the height of the footer from the calculations - Remember to remove all the .rooms-footer classes in webapp.css
Attachments
(3 files, 4 obsolete files)
83.35 KB,
image/png
|
sevaan
:
ui-review-
|
Details |
11.28 KB,
patch
|
standard8
:
review+
sevaan
:
ui-review+
|
Details | Diff | Splinter Review |
84.32 KB,
image/png
|
sevaan
:
ui-review+
|
Details |
As part of the ongoing work, we should remove the footer of the standalone. Suggest this work happens after bug 1205206.
See user story for details.
Reporter | ||
Comment 1•9 years ago
|
||
We probably want to do one of:
- create the logo element in MediaLayoutView and have a prop to toggle it on/off
- might be able to do it via passing in a child to MediaLayoutView & positioning.
- Or, just have it created & positioned via StandaloneRoomView.
I don't think I like the last two so much, as it would make it harder to position in the correct place - especially if we change the layout of the media view.
If we use a prop, we could have a generic thing like "enableLogos" or something, that would later apply to the Firefox Logo & maybe the Help icon (that we'll move in a separate bug).
Points: --- → 5
Rank: 21
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → david.critchley
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8668580 -
Flags: ui-review?(sfranks)
Attachment #8668580 -
Flags: review?(standard8)
Updated•9 years ago
|
Attachment #8668570 -
Attachment is obsolete: true
Comment 4•9 years ago
|
||
Ignore the mockup. Please use the floating footer in Vicky's link clicker mockups, matching it's functionality and styling.
Comment 5•9 years ago
|
||
Comment on attachment 8668580 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
Need a screenshot, thanks!
Attachment #8668580 -
Flags: ui-review?(sfranks)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8668580 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
Review of attachment 8668580 [details] [diff] [review]:
-----------------------------------------------------------------
Ok, so per Vicky's mocks, the mozilla logo should be displayed all the time, so I think you can drop that code. Apart from that, its looking good.
Attachment #8668580 -
Flags: review?(standard8)
Assignee | ||
Comment 7•9 years ago
|
||
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8668580 -
Attachment is obsolete: true
Attachment #8668730 -
Flags: review?(standard8)
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8668730 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
Review of attachment 8668730 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/loop/standalone/content/js/standaloneRoomViews.jsx
@@ +591,5 @@
> + * @private
> + */
> + _shouldShowLogo: function() {
> + if(this.props.showLogo) {
> + return this.props.showLogo;
What's the reason for keeping this optional functionality? I don't think it is worth it if we're not using it.
If there's a really good reason, then we need to add test coverage as well.
Attachment #8668730 -
Flags: review?(standard8) → review-
Assignee | ||
Comment 9•9 years ago
|
||
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8668730 -
Attachment is obsolete: true
Attachment #8669044 -
Flags: review?(standard8)
Reporter | ||
Comment 10•9 years ago
|
||
Comment on attachment 8669044 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
Review of attachment 8669044 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, r=Standard8. Don't forget Sevaan needs a screenshot for ui-review.
Attachment #8669044 -
Flags: review?(standard8) → review+
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8669149 -
Flags: ui-review?(sfranks)
Comment 12•9 years ago
|
||
Comment on attachment 8669149 [details]
Screenshot of changes for UI Review
The margins should all be even: http://i.sevaan.com/image/3Z0n1k0J3Y1H
Let's see it at 12px?
Also, could you include a screenshot of what this looks like over connected video?
Thanks!
Attachment #8669149 -
Flags: ui-review?(sfranks) → ui-review-
Assignee | ||
Comment 13•9 years ago
|
||
Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Attachment #8669044 -
Attachment is obsolete: true
Attachment #8669813 -
Flags: ui-review?(sfranks)
Attachment #8669813 -
Flags: review?(dmose)
Assignee | ||
Comment 14•9 years ago
|
||
Attachment #8669814 -
Flags: ui-review?(sfranks)
Comment 15•9 years ago
|
||
Comment on attachment 8669813 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
Reviewed with :dcritch over Vidyo
Attachment #8669813 -
Flags: ui-review?(sfranks) → ui-review+
Updated•9 years ago
|
Attachment #8669814 -
Flags: ui-review?(sfranks) → ui-review+
Assignee | ||
Comment 16•9 years ago
|
||
(In reply to David Critchley (:dcritch) from comment #13)
> Created attachment 8669813 [details] [diff] [review]
> Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
>
> Removing footer from Loop Standalone, moved Logo to mediaLayoutView
Added some scope to this bug, since I was in the area anyway. Fixing margins and size of Conversation Toolbar as per request from Sevaan, to line up with the Mozilla logo and vicki's mocks:
http://i.sevaan.com/image/2U0U0R0J2j13
Reporter | ||
Updated•9 years ago
|
Attachment #8669813 -
Flags: review?(dmose) → review?(standard8)
Reporter | ||
Comment 17•9 years ago
|
||
Comment on attachment 8669813 [details] [diff] [review]
Attachment to Bug 1209632 - Remove the footer of Loop's standalone page
Review of attachment 8669813 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, r=Standard8
Attachment #8669813 -
Flags: review?(standard8) → review+
Comment 19•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•9 years ago
|
Iteration: --- → 44.2 - Oct 19
You need to log in
before you can comment on or make changes to this bug.
Description
•