Closed Bug 1205239 Opened 10 years ago Closed 10 years ago

Allow cancellation of in progress synchronization

Categories

(Firefox OS Graveyard :: Sync, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S9 (16Oct)

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file)

The Sync app should be able to cancel an on going synchronization and the SyncManager should be able to request this cancellation. Cases where a cancellation is needed: - The user disables Sync while a synchronization is in progress. - The user logs out from FxA while a synchronization is in progress. - We add a specific button in the Settings UI to allow the user to cancel an on going synchronization.
Blocks: fxos-sync
Target Milestone: --- → FxOS-S8 (02Oct)
Assignee: nobody → ferjmoreno
Target Milestone: FxOS-S8 (02Oct) → FxOS-S9 (16Oct)
Target Milestone: FxOS-S9 (16Oct) → FxOS-S8 (02Oct)
Target Milestone: FxOS-S8 (02Oct) → FxOS-S9 (16Oct)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Ugh, wrong bug
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8669012 - Flags: review?(mbdejong)
Comment on attachment 8669012 [details] [review] [gaia] ferjm:bug1205239.cancelsync > mozilla-b2g:master Looks solid! :) I saw some "XXX FIXME : Dispatch a mozFxAccountsChromeEvent: undefined" being logged while trying it out, but it all seems to work. I did notice that if I disable my WiFi and then click "Sync Now", it also disables sync (which should not happen), but that's probably unrelated to this PR.
Attachment #8669012 - Flags: review?(mbdejong) → review+
(In reply to Michiel de Jong [:michielbdejong] from comment #4) > Comment on attachment 8669012 [details] [review] > [gaia] ferjm:bug1205239.cancelsync > mozilla-b2g:master > > Looks solid! :) I saw some "XXX FIXME : Dispatch a mozFxAccountsChromeEvent: > undefined" being logged while trying it out, but it all seems to work. > That's a false warning with chrome events without a type property https://mxr.mozilla.org/mozilla-central/source/b2g/components/SystemAppProxy.jsm#128. That's an old check from when we used more generic mozChromEvents. It's totally harmless. > I did notice that if I disable my WiFi and then click "Sync Now", it also > disables sync (which should not happen), but that's probably unrelated to > this PR. Oh, that's a bug then.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: