1205239 - Allow cancellation of in progress synchronization

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

The Sync app should be able to cancel an on going synchronization and the SyncManager should be able to request this cancellation. Cases where a cancellation is needed:

- The user disables Sync while a synchronization is in progress.
- The user logs out from FxA while a synchronization is in progress.
- We add a specific button in the Settings UI to allow the user to cancel an on going synchronization.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1205239.cancelsync > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/a3e13e4bea5fdbea870072af1a5b8f0cb03633b4

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Ugh, wrong bug

Comment 4

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8669012 [details] [review]
[gaia] ferjm:bug1205239.cancelsync > mozilla-b2g:master

Looks solid! :) I saw some "XXX FIXME : Dispatch a mozFxAccountsChromeEvent: undefined" being logged while trying it out, but it all seems to work.

I did notice that if I disable my WiFi and then click "Sync Now", it also disables sync (which should not happen), but that's probably unrelated to this PR.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Michiel de Jong [:michielbdejong] from comment #4)
> Comment on attachment 8669012 [details] [review]
> [gaia] ferjm:bug1205239.cancelsync > mozilla-b2g:master
> 
> Looks solid! :) I saw some "XXX FIXME : Dispatch a mozFxAccountsChromeEvent:
> undefined" being logged while trying it out, but it all seems to work.
> 

That's a false warning with chrome events without a type property https://mxr.mozilla.org/mozilla-central/source/b2g/components/SystemAppProxy.jsm#128. That's an old check from when we used more generic mozChromEvents. It's totally harmless.

> I did notice that if I disable my WiFi and then click "Sync Now", it also
> disables sync (which should not happen), but that's probably unrelated to
> this PR.

Oh, that's a bug then.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Bug 1212874

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/0f114c02efca8e5e1d0a3fcac7a2b8e8e6957701