1205877 - Support 3rd party search engines

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Like Android I'd like to be able to add site specific search engines for sites like ecosia.

Support forum thread about Ecosia:

https://support.mozilla.org/en-US/questions/1083936

Comment 1

[Richard Newman [:rnewman]]

We should be able to pull out proportions of engines from FHR. mfinkle might already have those numbers somewhere…

If you're a regular user of an engine we don't ship, this is a big pain point.

Comment 2

[Francesco Lodolo [:flod]]

I found this bug because a user was asking on our support forum how to add search engines, and got even more confused by this article
https://support.mozilla.org/en-US/kb/add-or-remove-search-engines-firefox-ios

Title is misleading (you can't add searchengines), and localized versions have a different set of searchplugins than en-US.

Not being able to add searchplugins might be a bigger problem for localized versions shipping with fewer searchplugins than en-US.

Comment 3

[Richard Newman [:rnewman]]

Maria, this should probably have an Aha card and be on your radar.

Comment 4

[Maria Popova]

Thanks - Created card FIOS-233 Support 3rd party search engines

Comment 5

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8753011 [details] [review]
Pull Request

Looking good! Left some more comments in the PR.

Comment 7

[Robin Andersen [:tecgirl]]

Comment on attachment 8753011 [details] [review]
Pull Request

Looks great! One nit on the toast font-weight (please increase by one weight).

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 8753011 [details] [review]
Pull Request

Looks and works great! Adding some finishing touches, then will go ahead and land since Farhan is on PTO until next week.

Comment 10

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/3c8f33c59364b4b8ba2e109080ddec6d1d165ab5