Closed Bug 1206989 Opened 9 years ago Closed 9 years ago

[browser] adding a Pocket link on TV browser

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(feature-b2g:2.5+)

Status:
RESOLVED FIXED
Milestone:
FxOS-S8 (02Oct)
Project Flags:
feature-b2g 2.5+

People

(Reporter: danhuang, Assigned: danhuang)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] danhuang1202:1206989_add_pocket_in_tv_browser > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
Details | Review 
Add Pocket home page link on TV browser
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
Summary: adding a Pocket link on TV browser → [browser] adding a Pocket link on TV browser
Blocks: TV_Pocket
Comment on attachment 8664744 [details] [review]
[gaia] danhuang1202:1206989_add_pocket_in_tv_browser > mozilla-b2g:master

Please help me to review. This patch add a pocket link in browser menu and a function clickPocketListBlock in toolbar.js to handle pocket list mouseup event. Thanks.
Attachment #8664744 - Flags: review?(yliao)
Comment on attachment 8664744 [details] [review]
[gaia] danhuang1202:1206989_add_pocket_in_tv_browser > mozilla-b2g:master

Great! Thanks! Please fix the nits before merging the patch.
Attachment #8664744 - Flags: review?(yliao) → review+
feature-b2g: --- → 2.5+
Priority: -- → P1
Target Milestone: --- → FxOS-S8 (02Oct)
Whiteboard: [partner-cherry-pick]
Thanks for the review.
merge in master:
https://github.com/mozilla-b2g/gaia/commit/387be286c9cad352208a438f637eeac50f2ad580
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Gaia::TV → Gaia::TV::Browser
See Also: → 1220380
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: