1207551 - Remove obsolete libpurple prpls

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Comment 1

[Patrick Cloke [:clokep]]

Which ones are 'obsolete'?

Comment 2

[aleth [:aleth]]

Attachment: Remove yahoo

This includes yahoojp.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8664802 [details] [diff] [review]
Remove yahoo

Review of attachment 8664802 [details] [diff] [review]:
-----------------------------------------------------------------

There are known bugs in the JS-Yahoo protocol. I wanted to do a release where we ship both (but with JS-Yahoo preffed on by default).

Comment 4

[aleth [:aleth]]

Attachment: Remove msn

Comment 5

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #3)
> There are known bugs in the JS-Yahoo protocol.

Aren't those just one or two bugs that could be fixed? 

> I wanted to do a release
> where we ship both (but with JS-Yahoo preffed on by default).

That makes a lot of sense, but then you'll have to fix bug 1204853 instead ;)

Comment 6

[Patrick Cloke [:clokep]]

(In reply to aleth [:aleth] from comment #5)
> (In reply to Patrick Cloke [:clokep] from comment #3)
> > There are known bugs in the JS-Yahoo protocol.
> 
> Aren't those just one or two bugs that could be fixed? 

It's at least bug 1118499. And sure, they can be fixed. But they're not. I know at least one person is depending on using the libpurple code right now.

> > I wanted to do a release
> > where we ship both (but with JS-Yahoo preffed on by default).
> 
> That makes a lot of sense, but then you'll have to fix bug 1204853 instead ;)

I disagree. I doubt the Yahoo commands are really used. Yes, it's a bit broken, but I don't think it will really get in the way. (How long have we been using XMPP this way?)

Comment 7

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #6)
> > > I wanted to do a release
> > > where we ship both (but with JS-Yahoo preffed on by default).
> > 
> > That makes a lot of sense, but then you'll have to fix bug 1204853 instead ;)
> 
> I disagree. I doubt the Yahoo commands are really used. Yes, it's a bit
> broken, but I don't think it will really get in the way. (How long have we
> been using XMPP this way?)

Actually, now we have JS-XMPP commands, it really gets in my way that they don't work. (But that's a discussion for the other bug.)

My point is, you can choose which of all these bugs are your blockers, but the number shouldn't be zero.

Comment 8

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #6)
> > Aren't those just one or two bugs that could be fixed? 
> 
> It's at least bug 1118499. And sure, they can be fixed. But they're not. I
> know at least one person is depending on using the libpurple code right now.

It's a bit sad we're shipping a yahoo prpl with TB which is that broken :-S

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 8664844 [details] [diff] [review]
Remove msn

Review of attachment 8664844 [details] [diff] [review]:
-----------------------------------------------------------------

Let's not check this in yet, as discussed above.

Comment 10

[aleth [:aleth]]

MSN
https://hg.mozilla.org/users/florian_queze.net/purple/rev/d4ef6e84d8a0

Comment 11

[aleth [:aleth]]

Attachment: Remove libpurple msn prpl

Unbitrotted remove yahoo

Comment 12

[aleth [:aleth]]

Attachment: Remove libpurple yahoo/yahoojp prpl

Unbitrotted remove yahoo

Comment 13

[Patrick Cloke [:clokep]]

I ended up doing the Yahoo parts in bug 1316000.