Closed Bug 1000469 Opened 10 years ago Closed 8 years ago

Yahoo doesn't normalize anything

Categories

(Chat Core :: Yahoo! Messenger, defect)

Product:
Chat Core
Component:
Yahoo! Messenger
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: clokep, Assigned: qheaden)

References

Details

Two issues here:
1. We don't normalize keys for data storage (e.g. _participants), I assume Yahoo is case-insensitive.
2. We directly check properties via _data[key] instead of using hasOwnProperty (from imXPCOMUtils).

This must be fixed before enabling by default.
(In reply to Patrick Cloke [:clokep] from comment #0)
> This must be fixed before enabling by default.

Oops :-(
Blocks: 1207551
Flags: needinfo?(qheaden)
I've now started work on this. I am starting with normalizing array property accesses, and then I will move to normalizing keys.
Flags: needinfo?(qheaden)
NormalizedMap.jsm might help? Also check the normalize() function you are using is correct for Yahoo.
Assignee: nobody → qheaden
Status: NEW → ASSIGNED
Yahoo completely changed their protocol, thus our old Yahoo bugs are obsolete. See bug 1316000 for more details.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.