1208003 - [TV 2.5] Implement the functionalities of the TV remote control app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Luke Chang [:lchang] (inactive)]

We have two options related to TV remote control.

- enable/disable remote control server
- enable/disable PIN code verification for pairing

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1208003_tv_remote_control_app > mozilla-b2g:master

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8671179 [details] [review]
[gaia] luke-chang:1208003_tv_remote_control_app > mozilla-b2g:master

Hi Evelyn,

This is the first bug of the TV remote control app. Please take a look.

Note that this bug depends on Bug 1212726 so I cherry-picked that patch in this pull request so you can review it more easily.

Thanks.

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8671179 [details] [review]
[gaia] luke-chang:1208003_tv_remote_control_app > mozilla-b2g:master

This patch achieves following tasks:

- a stand-alone TV remote control app
- showing server's IP on the screen
- showing error messages when server disabled or offline
- configuration page
- ability to revoke paired devices
- l10n

The remaining tasks are as follows:

- show the QRCode (Bug 1203853)
- apply the visual spec (Bug 1212402)

Comment 5

[Luke Chang [:lchang] (inactive)]

Please refer to [1] for the UX spec. Thanks.

[1] https://drive.google.com/folderview?id=0B5RN80W56Ga9Qkp1Mm5TTlNMTlE&usp=drive_web

Comment 6

[Evelyn Hung]

Comment on attachment 8671179 [details] [review]
[gaia] luke-chang:1208003_tv_remote_control_app > mozilla-b2g:master

Please see my github comments. Basically are renaming some variables, and add comments to make the code more readable. I suggest re-architecture a bit and let config section be more isolated from app.js.

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8671179 [details] [review]
[gaia] luke-chang:1208003_tv_remote_control_app > mozilla-b2g:master

Hi Evelyn,

I've addressed the comments and redesigned my structure. Since it's a big change, I keep the previous one on PR in case you'd like to refer to it during reviewing. Thanks.

Comment 8

[Evelyn Hung]

Comment on attachment 8671179 [details] [review]
[gaia] luke-chang:1208003_tv_remote_control_app > mozilla-b2g:master

r+ with comment addressed. Thanks.

Comment 9

[Luke Chang [:lchang] (inactive)]

tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f99179bf9443becb77e64453431e9a55f0cc6af8

landed on master: https://github.com/mozilla-b2g/gaia/commit/7b59f91935415bc88685c601f1c6181b986d6036