Closed Bug 1208083 Opened 6 years ago Closed 6 years ago

[NGA][NGA] Reenable search tests

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S10 (30Oct)

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(3 files)

Reenable search test
Assignee: nobody → hub
Blocks: 1193835
Depends on: 1196333
Depends on: 1209432
Status: NEW → ASSIGNED
Comment on attachment 8667601 [details] [review]
[gaia] hfiguiere:bug1208083-search-tests > mozilla-b2g:master

If we can get the first set of test? Thanks.
Attachment #8667601 - Flags: review?(jdarcangelo)
Comment on attachment 8667601 [details] [review]
[gaia] hfiguiere:bug1208083-search-tests > mozilla-b2g:master

LGTM... Ship it!
Attachment #8667601 - Flags: review?(jdarcangelo) → review+
Comment on attachment 8668569 [details] [review]
[gaia] hfiguiere:bug1208083-search-tests-part2 > mozilla-b2g:master

Now that we have a message for "No Music", test it.
Attachment #8668569 - Flags: review?(jdarcangelo)
Attachment #8668569 - Flags: review?(jdarcangelo) → review+
Merged
https://github.com/mozilla-b2g/gaia/commit/d829e035c067814b5dea58c027c5bcf35cb8b670
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
sorry there is still at least a 3rd part needed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
And this is what make gecko crash. :-/
Here is the crash I caught in the debugger:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f624d1ff700 (LWP 21017)]
0x000000000040a4e5 in mozalloc_abort(char const*) ()
(gdb) where
#0  0x000000000040a4e5 in mozalloc_abort(char const*) ()
(gdb)
Depends on: 1040927
Depends on: 1212694
Blocks: 1212694
No longer depends on: 1212694
Comment on attachment 8669708 [details] [review]
[gaia] hfiguiere:bug1208083-context-search > mozilla-b2g:master

As it is now, the test no longer crash Mulet. So here we go, let's get it in.
Attachment #8669708 - Flags: review?(jdarcangelo)
Removing blocker.
No longer depends on: 1040927
Attachment #8669708 - Flags: review?(jdarcangelo) → review+
Merged
https://github.com/mozilla-b2g/gaia/commit/df18f1c9c7c8d43ce95efdfb8a2df820e70d5027
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: FxOS-S8 (02Oct) → FxOS-S10 (30Oct)
You need to log in before you can comment on or make changes to this bug.