1196333 - [Music][NGA] Wire up front-end to search back-end

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Justin D'Arcangelo [:justindarc]]

The search boxes in the front-end for Music NGA need to be wired up to the back-end "search" API.

Comment 1

[Hema Koka [:hema]]

Jim,

Is there an update on this work? I thought we were on plan to land it last week. It is one of the last big pieces left and would like to get this in this sprint? What is pending? If it is possible to split it up between you and Justin and get that landed by end of the week (Sept 18th?), that would be awesome!

Thanks
Hema

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] jimporter:music-nga-search > mozilla-b2g:master

Comment 4

[Jim Porter (:squib)]

Comment on attachment 8663987 [details] [review]
[gaia] jimporter:music-nga-search > mozilla-b2g:master

This is about as far as I've been able to get without some help. Here are the issues I know of:

1) Tiles view's search needs to search artist, album, *and* title fields
2) Tapping on search results doesn't do anything
3) Search results can't be scrolled
4) The alphabetical for search results seem buggy, although maybe they should be removed and replaced with the field type being searched; I'm not sure how to embed the number of results in the category though
5) There's no "no search results" widget
6) Album and song results should have the artist listed as a subtitle
7) Search results seem to get out of sync with the text the user actually typed in sometimes

Any ideas? I can probably fix some of these on my own, although I'm not totally sure what the best way to handle a lot of the fast-list issues is.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8663987 [details] [review]
[gaia] jimporter:music-nga-search > mozilla-b2g:master

Looks good so far! This will need re-based on Bug 1205019 because the <gaia-fast-list> API has changed significantly. We can now declaratively define list item markup using a <template>.

Since your availability is limited this week and we need to land, would you mind if I take your PR and continue working on it? I can start addressing the issues you mentioned here as well as upgrading the <gaia-fast-list> usage.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

squib: This PR rebases your PR on top of Bug 1205019 (upgrades gaia-fast-list). I've also added another commit that addresses the issues you brought up in Comment 4.

One thing to note. You mentioned how the search results seem to be getting "out-of-sync" and I'm also experiencing this problem. The issue seems to be with gaia-fast-list where it is not properly invalidating previously-rendered list items. I let wilsonpage know and filed a bug for gaia-fast-list so we can get it resolved:

https://github.com/gaia-components/gaia-fast-list/issues/12

Comment 7

[Jim Porter (:squib)]

Comment on attachment 8664988 [details] [review]
pull-request (master)

Looks good overall, but see my comments on GitHub.

Comment 8

[Justin D'Arcangelo [:justindarc]]

(In reply to Jim Porter (:squib) from comment #7)
> Comment on attachment 8664988 [details] [review]
> pull-request (master)
> 
> Looks good overall, but see my comments on GitHub.

Your suggestion to create a whole new object and copy the properties over to it could potentially blow up our memory utilization. I don't see the harm in just amending the additional properties to the existing objects. Is this ok?

Comment 9

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8664988 [details] [review]
pull-request (master)

After discussing on IRC, addressed your comment. Please re-review.

Comment 10

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/5a226997b8bd317735ceec65c9e03b1e47a30b3c

Comment 11

[SandKing]

Attachment: Verified video: Flame_v2.5.3GP

This bug has been verified as pass on latest Flame v2.5.
STR:
Precondition: There are some music on device.
1. Flash build to "20150927150205"
2. Launch "Music NGA".
3. Invoke search bar and type some characters in the search field. 
See video: "Flame_2.5.3GP"

Actual result:
The music which matched with the  keywords you input on step3  will display.

Flame v2.5(pass):
Build ID               20150927150205
Gaia Revision          285486b417f1cb8316b19c0698a6655fc053fbd6
Gaia Date              2015-09-25 14:11:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150927.184956
Firmware Date          Sun Sep 27 18:50:08 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0