1208230 - [gatt] gaia-taskenv, tester images need to be updated to node v4

Status: RESOLVED DUPLICATE of bug 1223661

(Taskcluster :: Services, defect)

Description

[Aus Lacroix [:aus]]

We want to start using node v4 everywhere and the first step is to get the images updated and uploaded to be ready to be turned on.

It's straightforward, and I have the necessary credentials to update the images.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] nullaus:bug1208230 > mozilla-b2g:master

Comment 2

[Aus Lacroix [:aus]]

Attachment: bug1208230-v1.patch

In lieu of jonasfj, asking garndt for review.

Comment 3

[Aus Lacroix [:aus]]

So, while the pull request do update to 4.0 successfully we have several issues to overcome before this ends. There are quite a few dependent node modules which we're locked into version wise in gaia which will not work in 4.0 and we'll need to update those as necessary (and hope they still work as expected!)!

It's a start though...

Comment 4

[Greg Arndt [:garndt]]

Comment on attachment 8665858 [details] [diff] [review]
bug1208230-v1.patch

Review of attachment 8665858 [details] [diff] [review]:
-----------------------------------------------------------------

So right now this would be a r- because we should figure out the double installation of node in the tester image.  Also, since this effects all b2g related tests (desktop, emulator, device, mulet) we should push to try and figure out where the problems might be.  The image could be pushed out as a bogus tag for testing (such as 0.99.99) but we don't want to land this change and cause tests to start breaking that were once green because of package dependencies and other issues.

::: testing/docker/tester/Dockerfile
@@ +21,5 @@
>  RUN npm install -g taskcluster-npm-cache@1.1.14
>  RUN rm -Rf .cache && mkdir -p .cache
>  ENV PATH $PATH:/home/worker/bin
>  
> +# Use node 4.0.0 for tester to run Gij appropriately

Wouldn't we want to change this in testing/docker/base-test where the original version of node is getting installed? Or perhaps not have it installed in base-test at all and install it in just tester?  Not sure the super correct place to put it, I don't think anything else is using base-test.

Also, We are installing 0.10.36 in base-test, then installing packages under 0.10.36, and then upgrading node....are there any issues with doing that?  Seems it might be clearer to just install the version of node we want before anything else.

Comment 5

[Aus Lacroix [:aus]]

(In reply to Greg Arndt [:garndt] from comment #4)
> Comment on attachment 8665858 [details] [diff] [review]
> bug1208230-v1.patch
> 
> Review of attachment 8665858 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> So right now this would be a r- because we should figure out the double
> installation of node in the tester image.  Also, since this effects all b2g
> related tests (desktop, emulator, device, mulet) we should push to try and
> figure out where the problems might be.  The image could be pushed out as a
> bogus tag for testing (such as 0.99.99) but we don't want to land this
> change and cause tests to start breaking that were once green because of
> package dependencies and other issues.

Indeed!
 
> ::: testing/docker/tester/Dockerfile
> @@ +21,5 @@
> >  RUN npm install -g taskcluster-npm-cache@1.1.14
> >  RUN rm -Rf .cache && mkdir -p .cache
> >  ENV PATH $PATH:/home/worker/bin
> >  
> > +# Use node 4.0.0 for tester to run Gij appropriately
> 
> Wouldn't we want to change this in testing/docker/base-test where the
> original version of node is getting installed? Or perhaps not have it
> installed in base-test at all and install it in just tester?  Not sure the
> super correct place to put it, I don't think anything else is using
> base-test.

Yes, unfortunately base-test is missing sources.list(?) and can't be built.
 
> Also, We are installing 0.10.36 in base-test, then installing packages under
> 0.10.36, and then upgrading node....are there any issues with doing that? 
> Seems it might be clearer to just install the version of node we want before
> anything else.

Yeah, ideally we would want to install it there but base-test doesn't seem to build. It's missing sources.list. :/

Comment 6

[Greg Arndt [:garndt]]

Taking a look at this image, it appears this is the sources.list:

https://gist.github.com/gregarndt/92e960e6a76624307a24

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] nullaus:bug1208230 > mozilla-b2g:master

Comment 8

[Aus Lacroix [:aus]]

Attachment: Patch - v2 - Update base-test, tester to node v4

Comment 9

[Aus Lacroix [:aus]]

Comment on attachment 8684374 [details] [diff] [review]
Patch - v2 - Update base-test, tester to node v4

****, forgot to hg qrefresh before exporting this. This is out of date.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] nullaus:bug1208230 > mozilla-b2g:master

Comment 11

[Aus Lacroix [:aus]]

Opened a new bug hoping to resolve my autolander woes, it got really confused. :/

Comment 12

[Aus Lacroix [:aus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d5f897b90f6

Comment 13

[Pete Moore [:pmoore][:pete]]

Moving closed bugs across to new Bugzilla product "TaskCluster".