TaskCluster nodejs client should support node v4 and greater

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aus, Assigned: aus)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Fails to install because one of it's dependencies is too old to be compatible with node >=4. It's most likely a simple version bump.
(Assignee)

Comment 1

3 years ago
It's actually fine. It spews out a lot of complaints about it's optional deps failing to install which isn't great, but isn't terrible either.

sockjs-client (which is no longer supported and is superseded by sockjs) is one of the major ones.

:jonas, did you have any plans for update schedules for the client? Should we care about giving it some minor updates now so that it's optional deps that aren't compatible are removed? If we can move easily to sockjs instead of sockjs-client that'd probably be the best technically.
Flags: needinfo?(jopsen)
Created attachment 8683418 [details] [review]
Github PR for sockjs-client

Not sure this fixes everything for node 4.x support, but it's a start :)
Flags: needinfo?(jopsen)
Comment on attachment 8683418 [details] [review]
Github PR for sockjs-client

thoughts? Or will you be happy to see this land...
Attachment #8683418 - Flags: review?(aus)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8683418 [details] [review]
Github PR for sockjs-client

It looked like it would be fairly easy but yeah... tests seem to be angry. :) Feel free to r? again when they're passing and I'll look ASAP.
Attachment #8683418 - Flags: review?(aus) → feedback+
(Assignee)

Updated

3 years ago
Blocks: 1223661
It is preferable if we could also make sure old buildbots comes with the same NodeJS versions too. It's been painful to debug different environments offered on the TreeHerder...
(Assignee)

Comment 6

3 years ago
This was committed and we're already using it in the pull request for node 4 support. Thanks Jonas!

Commit: https://github.com/taskcluster/taskcluster-client/commit/60bbb2a4c4879027e4fa40da3dc3c7bf1b7ebf1e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

3 years ago
(In reply to Tim Guan-tin Chien [:timdream] (OOO Nov 16-26; please needinfo) from comment #5)
> It is preferable if we could also make sure old buildbots comes with the
> same NodeJS versions too. It's been painful to debug different environments
> offered on the TreeHerder...

Thankfully none of the old buildbots run Gij anymore. Any build doing that uses the same base docker image with the node version being defined there (base-test is the name of the docker image).
You need to log in before you can comment on or make changes to this bug.