1220005 - TaskCluster nodejs client should support node v4 and greater

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Aus Lacroix [:aus]]

Fails to install because one of it's dependencies is too old to be compatible with node >=4. It's most likely a simple version bump.

Comment 1

[Aus Lacroix [:aus]]

It's actually fine. It spews out a lot of complaints about it's optional deps failing to install which isn't great, but isn't terrible either.

sockjs-client (which is no longer supported and is superseded by sockjs) is one of the major ones.

:jonas, did you have any plans for update schedules for the client? Should we care about giving it some minor updates now so that it's optional deps that aren't compatible are removed? If we can move easily to sockjs instead of sockjs-client that'd probably be the best technically.

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Github PR for sockjs-client

Not sure this fixes everything for node 4.x support, but it's a start :)

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8683418 [details] [review]
Github PR for sockjs-client

thoughts? Or will you be happy to see this land...

Comment 4

[Aus Lacroix [:aus]]

Comment on attachment 8683418 [details] [review]
Github PR for sockjs-client

It looked like it would be fairly easy but yeah... tests seem to be angry. :) Feel free to r? again when they're passing and I'll look ASAP.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

It is preferable if we could also make sure old buildbots comes with the same NodeJS versions too. It's been painful to debug different environments offered on the TreeHerder...

Comment 6

[Aus Lacroix [:aus]]

This was committed and we're already using it in the pull request for node 4 support. Thanks Jonas!

Commit: https://github.com/taskcluster/taskcluster-client/commit/60bbb2a4c4879027e4fa40da3dc3c7bf1b7ebf1e

Comment 7

[Aus Lacroix [:aus]]

(In reply to Tim Guan-tin Chien [:timdream] (OOO Nov 16-26; please needinfo) from comment #5)
> It is preferable if we could also make sure old buildbots comes with the
> same NodeJS versions too. It's been painful to debug different environments
> offered on the TreeHerder...

Thankfully none of the old buildbots run Gij anymore. Any build doing that uses the same base docker image with the node version being defined there (base-test is the name of the docker image).