1209477 - [Music][NGA] Add alphabetical picker to all list views

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1209477 > mozilla-b2g:master

Comment 2

[Hubert Figuiere [:hub]]

This is likely bug 913903 that was for OGA.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8667252 [details] [review]
[gaia] wilsonpage:1209477 > mozilla-b2g:master

LGTM

Comment 5

[Hubert Figuiere [:hub]]

We should also write a test for it. IMHO.

Comment 6

[Justin D'Arcangelo [:justindarc]]

(In reply to Hubert Figuiere [:hub] from comment #5)
> We should also write a test for it. IMHO.

This should already be covered by <gaia-fast-list> tests:

https://github.com/gaia-components/gaia-fast-list/blob/master/test/test.js#L457

Although, these aren't run on Treeherder, the gaia-components/gaia-fast-list repo is covered by Travis CI.

Comment 7

[Wilson Page [:wilsonpage]]

https://github.com/mozilla-b2g/gaia/commit/d0f2f239f43304fbe12f31a5834a6c8a53a58288

Comment 8

[Wilson Page [:wilsonpage]]

The pickers still have room for improvement, but this will be done at the <gaia-fast-list> source-repo. If Music has any issues with pickers we can simple remove the `picker` attribute from <gaia-fast-list>.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Re-opening this so we remember to add the picker back in after Bug 1213381 lands.

Comment 10

[Justin D'Arcangelo [:justindarc]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #9)
> Re-opening this so we remember to add the picker back in after Bug 1213381
> lands.

To clarify: "after Bug 1213381 lands" *and* the l10n issues with it are resolved

Comment 12

[BMO Automation]

Firefox OS is not being worked on