Closed Bug 1209864 Opened 4 years ago Closed 4 years ago

Remove usage of decoder monitor from MediaOmxCommonDecoder

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

https://hg.mozilla.org/mozilla-central/file/acdb22976ff8/dom/media/omx/MediaOmxCommonDecoder.cpp#l49

This must be done before bug 1208934 because CheckDecoderCanOffloadAudio() is called from multiple threads. We will make all methods of MediaOmxCommonDecoder run on the main thread in this bug.
Assignee: nobody → jwwang
Depends on: 1053186
CheckDecoderCanOffloadAudio() is introduced in bug 1053186. Make sure not to cause regression when fixing this bug.
Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.
Attachment #8668226 - Flags: review?(roc)
Bug 1209864. Part 2 - remove unused code.
Attachment #8668227 - Flags: review?(roc)
It looks like roc is on PTO.
Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.
Attachment #8668226 - Flags: review?(roc) → review?(sotaro.ikeda.g)
Comment on attachment 8668227 [details]
MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.

Bug 1209864. Part 2 - remove unused code.
Attachment #8668227 - Flags: review?(roc) → review?(sotaro.ikeda.g)
Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

https://reviewboard.mozilla.org/r/20905/#review19041
Attachment #8668226 - Flags: review?(sotaro.ikeda.g) → review+
Comment on attachment 8668227 [details]
MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.

https://reviewboard.mozilla.org/r/20907/#review19039
Attachment #8668227 - Flags: review?(sotaro.ikeda.g) → review+
Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

https://reviewboard.mozilla.org/r/20905/#review19055

::: dom/media/omx/MediaOmxCommonDecoder.cpp:91
(Diff revision 1)
> +    GetStateMachine()->DispatchAudioOffloading(false);

It might be better to add a comment why the call is necessary. Because MDSM's default value is false.

::: dom/media/omx/MediaOmxCommonDecoder.cpp:102
(Diff revision 1)
> +    GetStateMachine()->DispatchAudioOffloading(false);

Same as above.
Attachment #8668226 - Flags: review+
Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.
Attachment #8668226 - Flags: review?(sotaro.ikeda.g)
Comment on attachment 8668227 [details]
MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.

Bug 1209864. Part 2 - remove unused code. r=sotaro.
Attachment #8668227 - Attachment description: MozReview Request: Bug 1209864. Part 2 - remove unused code. → MozReview Request: Bug 1209864. Part 2 - remove unused code. r=sotaro.
Comment on attachment 8668226 [details]
MozReview Request: Bug 1209864. Part 1 - make all methods run on the main thread and remove usage of the decoder monitor.

https://reviewboard.mozilla.org/r/20905/#review19077
Thanks for the review!
Attachment #8668226 - Flags: review?(sotaro.ikeda.g)
You need to log in before you can comment on or make changes to this bug.