1210356 - Make WebCryptoTransformer safer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect)

Description

[Michiel de Jong [:michielbdejong]]

In https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/sync-engine/syncengine.js#L112-L113 (and to some extent also in https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/sync-engine/syncengine.js#L121-L122) we make the assumption that the record contains no other fields than `id` and `payload`. If a DataAdapter would add other fields than that, they would be uploaded unencrypted. Safer would be:

return {
  id: record.id,
  payload
};

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1210356-safer-WebCryptoTransformer > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8668437 [details] [review]
[gaia] michielbdejong:1210356-safer-WebCryptoTransformer > mozilla-b2g:master

Thank you Michiel. The PR needs to be rebased.

Comment 3

[Michiel de Jong [:michielbdejong]]

Rebased. Thanks for all your review work today!! We're starting to get really close now to tying it all together. :)

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Yes, we're very close!

There's a failing test that needs to be fixed before merging.

Comment 5

[Michiel de Jong [:michielbdejong]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #4)
> Yes, we're very close!
> 
> There's a failing test that needs to be fixed before merging.

Oops! Merge error, and I forgot to re-run tests before pushing. My bad, fixed now.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

There is still one failing test (ESL)

Comment 7

[Michiel de Jong [:michielbdejong]]

Green now, after a rebase. Sorry, should have checked that myself before needinfo'ing you.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Awesome, thank you Michiel!

https://github.com/mozilla-b2g/gaia/commit/0c3249c06bddb174fa868e2dc1ea0ac0c1588bd8