1211537 - last_modified value is removed from Syncto records

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

I see a bunch of:

Incorrect payload::last_modified?  Object { id: "EwmY3piUMWfW", histUri: "https://www.mozilla.org/projects/fi…", title: null, visits: Array[1] } history.js:235:9
Incorrect payload::last_modified?  Object { id: "FzgmULBOdq5J", histUri: "http://mailinator.com/", title: "Mailinator", visits: Array[1] } history.js:235:9
Incorrect payload::last_modified?  Object { id: "J3HaEtVSjs1O", histUri: "http://click1.clickrouter.com/redir…", title: null, visits: Array[1] } history.js:235:9
Incorrect payload::last_modified?  Object { id: "Ly73dnw-Cs_2", histUri: "http://mailinator.com/inbox.jsp?to=…", title: "[1] Mailinator - Free. Disposable. …", visits: Array[1] } history.js:235:9
Incorrect payload::last_modified?  Object { id: "MaKvwT0OMua-", histUri: "https://accounts.firefox.com/verify…", title: "Firefox Accounts", visits: Array[1] } history.js:235:9
Incorrect payload::last_modified?  Object { id: "RQ0AuCQZN2p3", histUri: "http://mailinator.com/inbox.jsp?to=…", title: "[1] Mailinator - Free. Disposable. …", visits: Array[1] } history.js:235:9
Incorrect payload::last_modified?  Object { id: "Wep-omBZ8B8Z", histUri: "https://www.google.es/?gws_rd=ssl", title: "Google", visits: Array[1] } history.js:235:9

This looks like a regression from Bug 1210356.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1211537.synclastmodified > mozilla-b2g:master

Comment 2

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8669805 [details] [review]
[gaia] ferjm:bug1211537.synclastmodified > mozilla-b2g:master

Thanks for fixing this! Please only download last_modified (don't upload it) and add the missing unit tests to check exactly which fields are uploaded and downloaded (sorry, those unit tests should actually already exist, my bad!)

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/a3e13e4bea5fdbea870072af1a5b8f0cb03633b4