Show the URL bar dropmarker on toolbar hover instead of location bar hover

RESOLVED FIXED in Firefox 44

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 affected, firefox44 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Bug 1203494 made the URL bar dropmarker only appear when the location bar is hovered, but that requires high precision and some specific directional movement of the mouse to trigger it with high possibility of stopping the mouse where the dropmarker will appear.

Also, as a user who frequently uses the dropmarker, I find that it disappears too quickly if I accidentally overshoot the location bar and the mouse stops on the tabstrip above the navigation toolbar.
status-firefox43: --- → affected
Created attachment 8669385 [details] [diff] [review]
Patch

This patch is an improvement over what we currently are doing, but the #navigator-toolbox doesn't get :hover when hovering over the #TabsToolbar in an area that is absent of tabs (at least on Windows). I don't know what we can do about that, but if we can't do anything about that at least this patch makes it incrementally better.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8669385 - Flags: review?(dao)
Comment on attachment 8669385 [details] [diff] [review]
Patch

> .urlbar-history-dropmarker {
>   -moz-appearance: toolbarbutton-dropdown;
>   transition: opacity 0.15s ease;
>+  opacity: 0;
> }
> 
>-#urlbar:not(:hover) > .urlbar-textbox-container > .urlbar-history-dropmarker {
>-  opacity: 0;
>+#navigator-toolbox:hover .urlbar-textbox-container > .urlbar-history-dropmarker {
>+  opacity: 1;
> }

I don't understand why you changed the logic here rather than just updating the selector.
Attachment #8669385 - Flags: review?(dao)
Created attachment 8670540 [details] [diff] [review]
Patch v2

Sorry, I had initially approached the patch by writing selectors for each toolbar and inverted the logic until I realized I wouldn't be able to write a selector for the #PersonalToolbar which is after the #navbar. When I switched it to using the #navigator-toolbox I didn't think about reverting the logic to the pre-patch approach.
Attachment #8669385 - Attachment is obsolete: true
Attachment #8670540 - Flags: review?(dao)
Comment on attachment 8670540 [details] [diff] [review]
Patch v2

>-#urlbar:not(:hover) > .urlbar-textbox-container > .urlbar-history-dropmarker {
>+#navigator-toolbox:not(:hover) .urlbar-textbox-container > .urlbar-history-dropmarker {
>   opacity: 0;
> }

".urlbar-textbox-container > " is redundant now that you're not using the child selector all the way.

r=me with this removed
Attachment #8670540 - Flags: review?(dao) → review+
Created attachment 8670890 [details] [diff] [review]
Patch for check-in

Thanks, carrying forward r+
Attachment #8670540 - Attachment is obsolete: true
Attachment #8670890 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/78cf8ddd23cb
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44

Updated

3 years ago
Depends on: 1220486

Updated

2 years ago
Depends on: 1238638
Depends on: 1401507
You need to log in before you can comment on or make changes to this bug.