1211709 - Addon script does not get inserted on app startup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Load the attached clock addon in WebIDE.
2. Install on device while clock app is running.
3. Enable addon in settings.
4. Observe that in logcat "hello world" is printed - the script runs.
5. Quit the clock app.
6. Launch the clock app again.

Result: The script is not executed on startup.

Expected: The script should execute on startup.

Comment 1

[Eitan Isaacson [:eeejay]]

Looks like a regression in the new addon API from bug 1190995.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: test-addon.zip

Comment 3

[[:fabrice] Fabrice Desré]

I'll check that later today but I'm really surprised as one of my test addons is the "snappy twitter" which is injected at startup and worked fine.

Comment 4

[[:fabrice] Fabrice Desré]

Everything works for me with the patch from bug 1212089 applied.

Comment 5

[Eitan Isaacson [:eeejay]]

I still don't see this working. I applied the patch in bug 1212089, no change.

Comment 6

[[:fabrice] Fabrice Desré]

Can you attach a logcat dump?

Comment 7

[Eitan Isaacson [:eeejay]]

So I dived into this a bit yesterday. It looks like initialProcessData is empty in the content process. We rely on that to have the list of active addons after the process is started. But what happens is that we prelaunch the content process (dom.ipc.processPrelaunch.enabled) before initialProcessData is populated :P

Comment 8

[Eitan Isaacson [:eeejay]]

Bill,

As the original author of initialProcessData, should it be fixed to work with prelaunched processes? Or should we just never rely on initialProcessData.

I think a natural place for this would be in ContentParent::ForwardKnownInfo() after we transform a preallocation into an app/browser.

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I think it does make sense for us to make this work. ContentParent::ForwardKnownInfo() seems like a reasonable place to send the data.

Comment 10

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Any chance you can take a look at this Fabrice?

Comment 11

[[:fabrice] Fabrice Desré]

Yes, I will take a look.

Comment 12

[[:fabrice] Fabrice Desré]

This is actually fixed by the patch in bug 1214133 where we change the way we preload the extension code for perf reasons. One stone, two birds.

Feel free to re-open if you hit that again.

Comment 14

[kumar rishav (:rishav_)]

I was testing the sample add-on https://github.com/mdn/simple-addon .
It was working as expected when injected in system app. But when i injected same in SMS app (replaced 'system' with 'sms'). It didn't work as expected.

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to kumar rishav (:rishav_) from comment #14)
> I was testing the sample add-on https://github.com/mdn/simple-addon .
> It was working as expected when injected in system app. But when i injected
> same in SMS app (replaced 'system' with 'sms'). It didn't work as expected.

Kumar, what was your buildID?

Comment 16

[kumar rishav (:rishav_)]

Version 44.0a1 (2015-10-19)
Source

Built from https://hg.mozilla.org/mozilla-central/rev/1a157155a4fe0074b3d03b54fe9e466472c2cd56

Build platform
target
x86_64-unknown-linux-gnu

Thanks

Comment 17

[kumar rishav (:rishav_)]

Name 	Firefox
Version 	44.0a1
Build ID 	20151019030227

Comment 18

[Michael Henretty [:mikehenrty][:mhenretty]]

It looks like the CSS file is not getting loaded properly in the SMS app. I see the JS file running fine though. Let's use bug 1216543 to track it. Thanks for the report Kumar!

Comment 19

[kumar rishav (:rishav_)]

Hi Michael,
But sample add-on (MDN sample add-on) doesn't have any css file. Still it's not working in any app other than system. Can you point out to any working add-on (github link) which is injected in app other than system.

Thanks

Comment 20

[Michael Henretty [:mikehenrty][:mhenretty]]

The sample add-on does indeed have a css [1]. Here's an add-on that is injected into the twitter app [2].

1.) https://github.com/mdn/simple-addon/blob/69c8ee451d91649dcbf9f9d37f48a2bb40a0141b/manifest.json#L9
2.) https://github.com/etiennesegonzac/snappy-twitter

Comment 21

[kumar rishav (:rishav_)]

Hi Michael, 
Thanks for the links.

Sorry, but i tried without css files, but still result is same.
Here you can find the sample add-on. https://github.com/kumarrishav/sampleAddon

Please help, where i am doing wrong. This addon is not getting injected anywhere other than system.

Comment 22

[Michael Henretty [:mikehenrty][:mhenretty]]

Ah, you know what, I bet you are running into bug 1220700.

Comment 23

[kumar rishav (:rishav_)]

Yeah, i think, you are right. Some issue with new build of FxOS. 

Will try with old builds.

Thanks