Closed Bug 1211954 Opened 6 years ago Closed 6 years ago
(Gaia RTL 2
.5) CSS refactoring: Dialer
46 bytes, text/x-github-pull-request
|Details | Review|
Improve the RTL support of the Dialer app.
Assignee: nobody → pierre-eric
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
I've quickly glanced over the PR and this looks like really good stuff. The only issue I foresee is that we haven't yet updated the xpcshell we use in the gaia build system (it's stuck at version 39) and this will cause the CSS linter to fail on certain non-prefixed attributes (e.g. padding-inline-* and margin-inline-*).
The matching errors has been added to the xfail.list (which will be cleanup up as soon as gaia build system is updated).
OK, good to know. Let's file a follow up to clean them up after we land this bug.
PR updated. Now that gaia-header rtl refactoring has landed (https://bugzilla.mozilla.org/show_bug.cgi?id=1209041) this PR can be reviewed. Main bugs fixed: keypad layout, call details view layout.
Comment on attachment 8670345 [details] [review] [gaia] Phoxygen:bug1211954-dialer-rtl-css-refactoring > mozilla-b2g:master This is excellent work, thanks!
Attachment #8670345 - Flags: review?(gsvelto) → review+
Merged on master: https://github.com/mozilla-b2g/gaia/commit/5da94da9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.