1211954 - (Gaia RTL 2.5) CSS refactoring: Dialer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[pelloux]

Improve the RTL support of the Dialer app.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1211954-dialer-rtl-css-refactoring > mozilla-b2g:master

Comment 2

[Gabriele Svelto [:gsvelto]]

I've quickly glanced over the PR and this looks like really good stuff. The only issue I foresee is that we haven't yet updated the xpcshell we use in the gaia build system (it's stuck at version 39) and this will cause the CSS linter to fail on certain non-prefixed attributes (e.g. padding-inline-* and margin-inline-*).

Comment 3

[pelloux]

The matching errors has been added to the xfail.list (which will be cleanup up as soon as gaia build system is updated).

Comment 4

[Gabriele Svelto [:gsvelto]]

OK, good to know. Let's file a follow up to clean them up after we land this bug.

Comment 5

[pelloux]

PR updated. Now that gaia-header rtl refactoring has landed (https://bugzilla.mozilla.org/show_bug.cgi?id=1209041) this PR can be reviewed.

Main bugs fixed: keypad layout, call details view layout.

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8670345 [details] [review]
[gaia] Phoxygen:bug1211954-dialer-rtl-css-refactoring > mozilla-b2g:master

This is excellent work, thanks!

Comment 7

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/5da94da9