1212188 - Disable non-text/rich text support for B2G clipboard on 2.5 branch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Boris Chiou [:boris]]

According to Bug 952456 Comment 81, we added a new pref to toggle the non-text/rich text support for B2G clipboard on master branch in Bug 1210265. The default behavior is to enable non-text/rich text support. However, we will disable this feature once we branch if needed (Bug 1210265 Comment 7).

Comment 1

[Boris Chiou [:boris]]

BTW, the preference name is "clipboard.plainTextOnly", and its default value is false.
(https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js?from=all.js#2011)

Comment 2

[Mahendra Potharaju [:mahe]]

Removing from 2.5 blocker list. To be handled as a task

Comment 3

[Boris Chiou [:boris]]

Attachment: Enable plainTextOnly pref for Clipboard API

Comment 4

[Boris Chiou [:boris]]

Attachment: Enable plainTextOnly pref for Clipboard API (v2)

Comment 5

[Boris Chiou [:boris]]

This bug can also fix Bug 1207083 and Bug 1224045.

Comment 6

[Boris Chiou [:boris]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d835ab56a92

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:

Comment 8

[[:fabrice] Fabrice Desré]

Comment on attachment 8686969 [details] [diff] [review]
Enable plainTextOnly pref for Clipboard API (v2)

Review of attachment 8686969 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed. Beware to only land on b2g44_2.5

::: b2g/app/b2g.js
@@ +1156,5 @@
>  #ifdef MOZ_GRAPHENE
>  #include ../graphene/graphene.js
>  #endif
> +
> +// Clipboard only supports text/plain

nits: move that before the #ifdef MOZ_GRAPHENE and add a full stop at the end of the comment.

Comment 9

[Boris Chiou [:boris]]

Attachment: Enable plainTextOnly pref for Clipboard API (v3, carry fabrice's r+)

Comment 10

[Boris Chiou [:boris]]

Hi, Sheriff,

Please only land on b2g44_2.5.

Thanks.

Comment 11

[Carsten Book [:Tomcat]]

(In reply to Boris Chiou [:boris] from comment #10)
> Hi, Sheriff,
> 
> Please only land on b2g44_2.5.
> 
> Thanks.

2.5 is approval only - so cc'ing mahe for approval request

Comment 12

[Mahendra Potharaju [:mahe]]

Comment on attachment 8687633 [details] [diff] [review]
Enable plainTextOnly pref for Clipboard API (v3, carry fabrice's r+)

Approved for 2.5 uplift. 

Thanks

Comment 13

[Carsten Book [:Tomcat]]

(In reply to Mahendra Potharaju [:mahe] from comment #12)
> Comment on attachment 8687633 [details] [diff] [review]
> Enable plainTextOnly pref for Clipboard API (v3, carry fabrice's r+)
> 
> Approved for 2.5 uplift. 
> 
> Thanks

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8ec849999b0b