Closed Bug 1212188 Opened 4 years ago Closed 4 years ago

Disable non-text/rich text support for B2G clipboard on 2.5 branch

Categories

(Firefox OS Graveyard :: Runtime, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.5?, b2g-v2.5 fixed)

RESOLVED FIXED
blocking-b2g 2.5?
Tracking Status
b2g-v2.5 --- fixed

People

(Reporter: boris, Assigned: boris)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

According to Bug 952456 Comment 81, we added a new pref to toggle the non-text/rich text support for B2G clipboard on master branch in Bug 1210265. The default behavior is to enable non-text/rich text support. However, we will disable this feature once we branch if needed (Bug 1210265 Comment 7).
Depends on: 1210265
BTW, the preference name is "clipboard.plainTextOnly", and its default value is false.
(https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js?from=all.js#2011)
Removing from 2.5 blocker list. To be handled as a task
blocking-b2g: 2.5? → ---
Assignee: nobody → boris.chiou
Blocks: 1224045
Attachment #8686967 - Attachment is obsolete: true
Attachment #8686969 - Flags: review?(fabrice)
This bug can also fix Bug 1207083 and Bug 1224045.
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Comment on attachment 8686969 [details] [diff] [review]
Enable plainTextOnly pref for Clipboard API (v2)

Review of attachment 8686969 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed. Beware to only land on b2g44_2.5

::: b2g/app/b2g.js
@@ +1156,5 @@
>  #ifdef MOZ_GRAPHENE
>  #include ../graphene/graphene.js
>  #endif
> +
> +// Clipboard only supports text/plain

nits: move that before the #ifdef MOZ_GRAPHENE and add a full stop at the end of the comment.
Attachment #8686969 - Flags: review?(fabrice) → review+
Attachment #8686969 - Attachment is obsolete: true
Keywords: checkin-needed
Hi, Sheriff,

Please only land on b2g44_2.5.

Thanks.
(In reply to Boris Chiou [:boris] from comment #10)
> Hi, Sheriff,
> 
> Please only land on b2g44_2.5.
> 
> Thanks.

2.5 is approval only - so cc'ing mahe for approval request
Flags: needinfo?(boris.chiou)
Comment on attachment 8687633 [details] [diff] [review]
Enable plainTextOnly pref for Clipboard API (v3, carry fabrice's r+)

Approved for 2.5 uplift. 

Thanks
Flags: needinfo?(boris.chiou)
Attachment #8687633 - Flags: approval‑mozilla‑b2g44+
(In reply to Mahendra Potharaju [:mahe] from comment #12)
> Comment on attachment 8687633 [details] [diff] [review]
> Enable plainTextOnly pref for Clipboard API (v3, carry fabrice's r+)
> 
> Approved for 2.5 uplift. 
> 
> Thanks

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8ec849999b0b
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.