[B2G][Emulator] Implement console command to support changing NITZ timezone.

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: freesamael, Assigned: freesamael)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In order to write test cases for NITZ, we need a new console command to set NITZ timezone on emulator.
Assignee: nobody → sawang
Blocks: 1090359
Blocks: 1209892
Created attachment 8670697 [details] [review]
Add "gsm timezone" console command. r=echen
Blocks: 1217277
Comment on attachment 8670697 [details] [review]
Add "gsm timezone" console command. r=echen

Marionette test on try [1] looks good. I think we can start reviewing the emulator feature first. The test is covered by the marionette test case in bug 1209892.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=227c16b91495
Attachment #8670697 - Attachment description: add "gsm timezone" console command → Add "gsm timezone" console command
Attachment #8670697 - Flags: review?(echen)

Comment 3

3 years ago
Comment on attachment 8670697 [details] [review]
Add "gsm timezone" console command. r=echen

I left some comments on github. Thank you.
Attachment #8670697 - Flags: review?(echen)
Comment on attachment 8670697 [details] [review]
Add "gsm timezone" console command. r=echen

Hi Edgar,

I've updated the patch. Could you take a look?
Attachment #8670697 - Flags: review?(echen)

Comment 5

3 years ago
Comment on attachment 8670697 [details] [review]
Add "gsm timezone" console command. r=echen

r=me with the comments on github addressed. Thank you.
Attachment #8670697 - Flags: review?(echen) → review+
Attachment #8670697 - Attachment description: Add "gsm timezone" console command → Add "gsm timezone" console command. r=echen

Comment 6

3 years ago
b2g-kitkat:
https://github.com/mozilla-b2g/platform_external_qemu/commit/5a50f96a1d7c788817abb7c57acbb75172c1f48d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.