121260 - gtk2 needs to have sound hooked up

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Christopher Blizzard (:blizzard)]

gtk2 need to have the sound interface hooked up.

Comment 1

[Christian Schaller]

Considered using GStreamer for this? 
OEOne is using GStreamer as the media backend for their XUL based desktop. And
it will also be the media backend for GNOME 2, starting from GNOME 2.2

Comment 2

[Robin Lu]

Attachment: patch

porting from widget/src/gtk
most same as in Gtk
By this patch, we can hear the email recieved sound now.
seek r=?

Comment 3

[Christopher Blizzard (:blizzard)]

Comment on attachment 98093 [details] [diff] [review]
patch

r=blizzard

go ahead and check it in.

Comment 4

[Bolian Yin]

checked in Trunk.
Thanks for Robin, he has contributed many good patches for mozilla.

Comment 5

[Robin Lu]

due to bug 166917, NS_INIT_REFCNT was obsoleted and can not be used. It causes
compiling fail of nsSound.cpp

Comment 6

[Robin Lu]

Attachment: patch for compiling fail

according to bug 166917

Comment 7

[Frederic Crozat]

The initial patch is wrong : it will only work on system where libesd.so is
installed.. Meaning it REQUIRES devel package of esound installed, which is not
the case for 90% of desktop users..

It should try to load libesd.so.0 (we don't have any intention of breaking esd
binary compatibility in the near or distant future..)

Comment 8

[Christopher Blizzard (:blizzard)]

Attachment: fix build problem and try to load libesd.so.0 first.

Comment 9

[Robin Lu]

Should we also apply this libesd.so.0 to widget/src/gtk/nsSound.cpp?

Comment 10

[Robin Lu]

Comment on attachment 100423 [details] [diff] [review]
fix build problem and try to load libesd.so.0 first.

It is ok for me

Comment 11

[Christopher Blizzard (:blizzard)]

Checked in.  Bug #171088 opened to get this fixed in gtk1.2, too.