1234212 - Treeherder puppet config cleanup

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P3)

Description

[Ed Morley [:emorley]]

There are a few bits of cleanup we can do:
* the requirements in puppet files are no longer used as of bug 1146184
* the local settings python file is unused as of bug 1212822
* the separate rabbitmq environment variables can be removed now we've migrated to using BROKER_URL (bug 1228312)
* the custom newrelic.ini file is unused (and always has been; bug 1225634 made us use the in-repo one added by bug 1182425)
* the puppet robots.txt file is unused as of bug 1201033 (/bug 1199046)

Comment 1

[Ed Morley [:emorley]]

Attachment: Part 1: Remove robots.txt

Since it's no longer referenced by the Apache configs (we use the
in-repo copy)

Comment 2

[Ed Morley [:emorley]]

Attachment: Part 2: Remove custom New Relic Python.ini

Since similarly, we use the in-repo copy.

Comment 3

[Ed Morley [:emorley]]

Attachment: Part 3: Remove settings_local.py

Since as of bug 1212822 it's not imported.

Comment 4

[Ed Morley [:emorley]]

Attachment: Part 4: Remove unused requirements files

They've been set to ensure->absent for a while.

Comment 5

[Ed Morley [:emorley]]

Attachment: Part 5: Remove unused environment variables

* The TREEHERDER_DATABASE_* vars were combined into DATABASE_URL.
* NEW_RELIC_LOG is overridden by the value in our own newrelic.ini, which takes precedence.
* NEW_RELIC_ENVIRONMENT does nothing, since we don't have any environments defined in newrelic.ini.
* The TBPLBOT email/password is unused as of bug 1179310.

Comment 6

[Ed Morley [:emorley]]

Thank you for the reviews - I don't suppose you could check these in for me at some point (no rush at all). I only have read access :-)

Comment 7

[Kendall Libby [:fubar] (he/him)]

absolutely! been meaning to follow up on it, but holidays and short attention span theatre...  will try and clean them up tomorrow morning.

Comment 8

[Kendall Libby [:fubar] (he/him)]

committed, pushed, and restarted everything JIC.

Comment 9

[Ed Morley [:emorley]]

Many thanks :-)