Closed Bug 1214136 Opened 9 years ago Closed 9 years ago

(Gaia RTL 2.5) CSS refactoring: Browser (Search)

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S10 (30Oct)
Tracking Status
b2g-master --- fixed

People

(Reporter: autra, Assigned: autra)

References

Details

Attachments

(1 file)

This bug is for the CSS refactoring of the Browser Chrome, following the new BiDi guidelines.
Blocks: 1181921
Assignee: nobody → augustin.trancart
Comment on attachment 8675535 [details] [review]
[gaia] Phoxygen:bug1214136-search_rtl_refacto > mozilla-b2g:master

Hi Kevin,

This patch is mainly a refacto to follow the BiDi guidelines. The only issues I found were some wrong alignment in search result. ALso corrected in this patch.

Please r?
Attachment #8675535 - Flags: review?(kevingrandon)
Comment on attachment 8675535 [details] [review]
[gaia] Phoxygen:bug1214136-search_rtl_refacto > mozilla-b2g:master

This seems fine to me, thank you!
Attachment #8675535 - Flags: review?(kevingrandon) → review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/a8980bc27e8ccfbf3b5934d537f15d9be7fc2fcc
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
Summary: (Gaia RTL 2.5) CSS refactoring: Browser → (Gaia RTL 2.5) CSS refactoring: Browser (Search)
Hey piwei,

Let's put new bugs in the meta bug for search (bug 1181921), not this one (it is only for the CSS refactoring, which is done).
No longer depends on: 1221367
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: